From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E542C04AA5 for ; Wed, 24 Aug 2022 23:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229569AbiHXXuS (ORCPT ); Wed, 24 Aug 2022 19:50:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbiHXXuO (ORCPT ); Wed, 24 Aug 2022 19:50:14 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F05EAE0F3 for ; Wed, 24 Aug 2022 16:50:07 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id p13so5678733pld.6 for ; Wed, 24 Aug 2022 16:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=Rtwz6fTrcBg1TFOL4QPsRuemhonZKT/5mDP1AugotzM=; b=E7AVGBdju1UilU2hXPAD9L9HDIi8n4+7AYJ4RUcSBRnETl2cJwY+/KYkuRgm9hjPxq 5sJeOck29St3C8/W/HJNzpu90bBcuMtKeoAxYdB1ONfwbA+3opFpQdjIsMWUue28wonP reaMSiF8olj9of04DketTD+5jIg69xEPL4dzNbo56JQmiAcjkQlxK9B7yJnSW/jFX/6c XB+5P1f1Gs0cjTJ5gdnmBD2Td+Hmp0GlikNorn79ayUxu99bTuzp/YY7ajNFjIA4CO7C UjCIcYx+FTpVEUT/+/E1jqkzZYkS2fq84cw4HBhShBBfE/jPEJI//fqKpq4X9WOOYBrf +5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Rtwz6fTrcBg1TFOL4QPsRuemhonZKT/5mDP1AugotzM=; b=FaEgYBRyqZYukFX2UhLwykWPoYNi4e62tf3w6iuxkAcOE0SCk1G/n9uPfHcMjs8zy3 M7wqJmmxAyt+xtzNIY/kJV4/XncCKKnPCtbgYsIToF1hZBixbR6qMMe3FYoIlDiWJAsp T/g37FPV/ezMfgAVQozo5s+iSCkEh8qnRu30MNaOJIyqKCkB6nSj0bcbOJFmqV/Q73W9 ruVKWwE4gI8h1OhoHcAgd4EJoKh3LXCoiSiKxdDxkqyxb5Kp7tulsTb6nqxrY9ubo7z2 VOHIMONC3KINDN1Jh12UTeyPdZj09Ux7YM989+XGhKjHraKzkOy2IjIkDwzAkq784a7L IG5Q== X-Gm-Message-State: ACgBeo1f/rrZfhZ3/NSBcYrF+1846IrU4ZEvWLTdSLm5CfHP9LjFx0vV Io41Ye9bPjKairiiIetmDkI8IQ== X-Google-Smtp-Source: AA6agR4fl4nEP7dCRJhxPprT2MslA2V+Sjpudndncruk7Aw8ByEaiFr52iVnF3+aNwZiEzdhhorhkA== X-Received: by 2002:a17:90b:4b8d:b0:1fb:4def:1fc1 with SMTP id lr13-20020a17090b4b8d00b001fb4def1fc1mr1528016pjb.121.1661385007388; Wed, 24 Aug 2022 16:50:07 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id n3-20020aa79843000000b005368341381fsm7842821pfq.106.2022.08.24.16.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 16:50:07 -0700 (PDT) Date: Wed, 24 Aug 2022 23:50:03 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Borislav Petkov , Dave Hansen , linux-kernel@vger.kernel.org, Wanpeng Li , Ingo Molnar , x86@kernel.org, Jim Mattson , Kees Cook , Thomas Gleixner , "H. Peter Anvin" , Joerg Roedel , Vitaly Kuznetsov , Paolo Bonzini Subject: Re: [PATCH v3 13/13] KVM: x86: emulator/smm: preserve interrupt shadow in SMRAM Message-ID: References: <20220803155011.43721-1-mlevitsk@redhat.com> <20220803155011.43721-14-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220803155011.43721-14-mlevitsk@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2022, Maxim Levitsky wrote: > @@ -518,7 +519,8 @@ struct kvm_smram_state_32 { > u32 reserved1[62]; > u32 smbase; > u32 smm_revision; > - u32 reserved2[5]; > + u32 reserved2[4]; > + u32 int_shadow; /* KVM extension */ Looking at this with fresh(er) eyes, I agree with Jim: KVM shouldn't add its own fields in SMRAM. There's no need to use vmcb/vmcs memory either, just add fields in kvm_vcpu_arch to save/restore the state across SMI/RSM, and then borrow VMX's approach of supporting migration by adding flags to do out-of-band migration, e.g. KVM_STATE_NESTED_SMM_STI_BLOCKING and KVM_STATE_NESTED_SMM_MOV_SS_BLOCKING. /* SMM state that's not saved in SMRAM. */ struct { struct { u8 interruptibility; } smm; } nested; That'd finally give us an excuse to move nested_run_pending to common code too :-)