Re: [PATCH 2/4] ARM: footbridge: remove leftover from personal-server

Russell King (Oracle)
2022-08-24T10:47:42Z

On Wed, Aug 24, 2022 at 12:37:15PM +0200, Arnd Bergmann wrote:
> On Sun, Aug 21, 2022 at 7:55 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > On Thu, Aug 18, 2022 at 11:15:48PM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > The machine was removed a while ago, and the checks are
> > > now useless.
> >
> > Curious, should entries for removed machines be kept in the mach-types
> > file? Because that makes it really easy to leave dead code like this
> > around.
>
> A long time ago it was common to add the entries in mach-types before
> the Kconfig symbol got merged, an Russell just updated the list
> periodically to drop stale entries. As we remove most board files in
> a coming release, we should probably do this as part of the bigger
> cleanup then.

The scripting I have for it doesn't understand "board was removed from
the kernel" so if I ever run the script in the future (unlikely) it'll
get re-added.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!