From: Greg KH <gregkh@linuxfoundation.org>
To: sean.wang@mediatek.com
Cc: stable@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Deren Wu <deren.wu@mediatek.com>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH 5.19] mt76: mt7921: fix command timeout in AP stop period
Date: Thu, 25 Aug 2022 13:59:05 +0200 [thread overview]
Message-ID: <YwdkCRXdOZCTdPQl@kroah.com> (raw)
In-Reply-To: <94065c608ee60d8a96a3d91913cb1e28d0a302e1.1661397440.git.objelf@gmail.com>
On Thu, Aug 25, 2022 at 11:27:22AM +0800, sean.wang@mediatek.com wrote:
> From: Deren Wu <deren.wu@mediatek.com>
>
> commit 9d958b60ebc2434f2b7eae83d77849e22d1059eb upstream.
>
> Due to AP stop improperly, mt7921 driver would face random command timeout
> by chip fw problem. Migrate AP start/stop process to .start_ap/.stop_ap and
> congiure BSS network settings in both hooks.
>
> The new flow is shown below.
> * AP start
> .start_ap()
> configure BSS network resource
> set BSS to connected state
> .bss_info_changed()
> enable fw beacon offload
>
> * AP stop
> .bss_info_changed()
> disable fw beacon offload (skip this command)
> .stop_ap()
> set BSS to disconnected state (beacon offload disabled automatically)
> destroy BSS network resource
>
> Fixes: 116c69603b01 ("mt76: mt7921: Add AP mode support")
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
> .../wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +
> .../net/wireless/mediatek/mt76/mt7921/main.c | 47 +++++++++++++++----
> .../net/wireless/mediatek/mt76/mt7921/mcu.c | 5 +-
> .../wireless/mediatek/mt76/mt7921/mt7921.h | 2 +
> 4 files changed, 43 insertions(+), 13 deletions(-)
Now queued up, thanks,
greg k-h
prev parent reply other threads:[~2022-08-25 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 3:27 [PATCH 5.19] mt76: mt7921: fix command timeout in AP stop period sean.wang
2022-08-25 11:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwdkCRXdOZCTdPQl@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=deren.wu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sean.wang@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox