From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAA4C04AA5 for ; Thu, 25 Aug 2022 12:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241963AbiHYMmy (ORCPT ); Thu, 25 Aug 2022 08:42:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241465AbiHYMmu (ORCPT ); Thu, 25 Aug 2022 08:42:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CFFAB4E8F for ; Thu, 25 Aug 2022 05:42:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 850E961892 for ; Thu, 25 Aug 2022 12:42:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52199C433D6; Thu, 25 Aug 2022 12:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661431368; bh=iTYFyWeLEjCrmEAev9v8sn5UwoXtJvvzq2kbPDZHMzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DyAe04jIUCNBLWedh3mqcHbPK2BVdKP2MkBjY+jtorOwkd8TIiNVejJaDDea2pU8i lHly2DbhkGPKJ7dVsJ8E0lAv+J41mRiUAQ5AgYRzAIFUqlNeN/18W2INLL38K5ZTQn ek5hqJSfj2ZO0tAbLEvMTx3GdMpdYTCJ4w1ur6tA= Date: Thu, 25 Aug 2022 14:42:46 +0200 From: Greg Kroah-Hartman To: "Czerwacki, Eial" Cc: "linux-kernel@vger.kernel.org" , "Arsh, Leonid" , "Twaig, Oren" , SAP vSMP Linux Maintainer , Arnd Bergmann , Dan Carpenter , Andra Paraschiv , Borislav Petkov , Brijesh Singh , Eric Biggers , Fei Li , Hans de Goede , Jens Axboe , Mauro Carvalho Chehab Subject: Re: [PATCH v2] drivers/virt/vSMP: new driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2022 at 12:38:46PM +0000, Czerwacki, Eial wrote: > >On Thu, Aug 25, 2022 at 12:02:12PM +0000, Czerwacki, Eial wrote: > >> >On Thu, Aug 25, 2022 at 10:41:28AM +0000, Czerwacki, Eial wrote: > >> >> >On Thu, Aug 25, 2022 at 10:16:59AM +0000, Czerwacki, Eial wrote: > >> >> >> >> >And why is your version file a binary file?  It should just be a small > >> >> >> >> >text string, right? > >> >> >> >> not so small, it can reach up to 512kb. > >> >> >> > > >> >> >> >That was not obvious at all.  Please document this. > >> >> >> where should the document be? > >> >> >> in the code as a comment or in another file? > >> >> > > >> >> >In the Documentation/ABI/ file that describes this file. > >> >> ok, will place it there > >> >> > >> >> > > >> >> >> >And how in the world is a "version" that big?  What exactly does this > >> >> >> >contain? > >> >> >> it 's size depends on the number of resources it uses. > >> >> >> here is an example: > >> >> >> :~> cat /sys/hypervisor/vsmp/version  > >> >> >> SAP vSMP Foundation: 10.6.2862.0 (Aug 22 2022 15:21:02) > >> >> >> System configuration: > >> >> >>    Boards:      2 > >> >> >>       1 x Proc. + I/O + Memory > >> >> >>       1 x NVM devices (Amazon.com Amazon EC2 NVMe Instance Storage) > >> >> >>    Processors:  1, Cores: 2, Threads: 4 > >> >> >>        Intel(R) Xeon(R) Platinum 8124M CPU @ 3.00GHz Stepping 04 > >> >> >>    Memory (MB): 30976 (of 103192), Cache: 7527, Private: 64689 > >> >> >>       1 x  6400MB    [ 7825/ 321/ 1104]      > >> >> >>       1 x 24576MB    [95367/7206/63585]       00:1f.0#1 > >> >> >>    Boot device: [HDD] NVMe: Amazon Elastic Block Store        > >> >> >> Supported until: Aug 22 2024 > >> >> > > >> >> >That is crazy, and is not a version.  It's a "configuration". > >> >> it is called version for history reasons... > >> > > >> >There is no "history" here, you can create whatever sane interface you > >> >want right now, there is no backwards compatible issues involved at all. > >> you are correct, however, it depends on how much change the hypervisor code requires > >> if any (latter is preferable) > > > >I do not understand, again, what tool consumes this today? > there are monitoring utils that parses it. What exact tools are you referring to, and why can you not change them? Where is the source for them? thanks, greg k-h