From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF48ECAAA3 for ; Fri, 26 Aug 2022 05:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244552AbiHZFxl (ORCPT ); Fri, 26 Aug 2022 01:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244943AbiHZFxi (ORCPT ); Fri, 26 Aug 2022 01:53:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 690B6D0752; Thu, 25 Aug 2022 22:53:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8A2361A18; Fri, 26 Aug 2022 05:53:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3912C433D6; Fri, 26 Aug 2022 05:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661493216; bh=VHnSXpnorzXm9YRmeeQW4ruB4c62oX2QKjpA2ehtdKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ov1Wc9rvWCHtSNO93LEyy9gkVGQ3MyEmzHEZyVdiJHjZ6DKF3p7iwEA5YLJSE+MfQ Zf5NlLiknoJP1Upac/SZ/vJ+IYl2asaQyUfzrBHZazSG/V8Qw7vrVPKQzQ5vjsOhwR lPu9lrp/0SWC3ieRi4mjUHWTagWNUQV8FKitK4SM0cnfHtVVrx4nBM7466EzLW5ysZ mZdtWKphjiGTMLoHIv26wdsI6b1ckjKdXWoigC1UU0LsChTGrBCOp7DS5+WQpgdGBb uBfde8YWmtHIeNA/A2ocHWq5rAuwuR/swltNkv3fwk0kzYcYoZEqrPvubnshal1PhP W0Gbzo23OGbhQ== Date: Fri, 26 Aug 2022 08:53:29 +0300 From: Jarkko Sakkinen To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org Subject: Re: [PATCH] char: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818205959.6576-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818205959.6576-1-wsa+renesas@sang-engineering.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2022 at 10:59:59PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- > drivers/char/tpm/tpm_ppi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c > index 40018a73b3cb..bc7b1b4501b3 100644 > --- a/drivers/char/tpm/tpm_ppi.c > +++ b/drivers/char/tpm/tpm_ppi.c > @@ -380,7 +380,7 @@ void tpm_add_ppi(struct tpm_chip *chip) > TPM_PPI_FN_VERSION, > NULL, ACPI_TYPE_STRING); > if (obj) { > - strlcpy(chip->ppi_version, obj->string.pointer, > + strscpy(chip->ppi_version, obj->string.pointer, > sizeof(chip->ppi_version)); > ACPI_FREE(obj); > } > -- > 2.35.1 > I can cope with this. Reviewed-by: Jarkko Sakkinen BR, Jarkko