From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C0BECAAD4 for ; Fri, 26 Aug 2022 13:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343761AbiHZNeE (ORCPT ); Fri, 26 Aug 2022 09:34:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344346AbiHZNeA (ORCPT ); Fri, 26 Aug 2022 09:34:00 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 282B6DC5DE for ; Fri, 26 Aug 2022 06:33:59 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id w2so1638166pld.0 for ; Fri, 26 Aug 2022 06:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=rWHO5zmUF7bZRGY8k3CrPBg15/SbyMngXXzYsL3BysI=; b=BVtuM9mKurY9NgLyr5DBTUimx39q+/B6q8hWHrCMcR7ZPHUmKpdIxVzhYTB0Izkrmb Yo+ht1MDnEe3k4E3rztZ/bdCo5yve76+yjrZZi9XR3KXDi6cio1xflou0lnxCtP1jzKP AxB1M6MFuUQqOZ7I8KAFFpBwvfZ+5bPVGofPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=rWHO5zmUF7bZRGY8k3CrPBg15/SbyMngXXzYsL3BysI=; b=JKhHjNNojUWNlYAcODXYRyP7G9kgM1JTv7g2tShf4sVcXvmfpcnV2nNrvtSVP5da3P qbDhqj4G5JFDWyw2G+/oGq+tF3uU6snZdESsJCfm4xKiZrXCVmuznS+KAifqPB/khc0v whyRqnWyRUNrI/oRHdsSUB697sRPnQzGgHhfOMQ+Cr5G/PW1O8yaXLu5N9pOYmxvdsif 2HTZRw0G0dNw46gW1H8Ab129Bb81fShdZ+8oxypDB5v3N/VbwtRWCeiAesQAoHJu//CT /PCaaRdmlVpxNQTqucSvYZpVIm9ulZAMVFCZjs7jqtx0TtNIuShobBaLhydy35yrIhwU SuSg== X-Gm-Message-State: ACgBeo3PZHYlaPPPL7um2R0k/u13+pHEDvtLIl73YhmTrAV+wdE+NlPN Yy9i94u3ALgMq0Gba72zKwSptA== X-Google-Smtp-Source: AA6agR5Qd66kzZf/KIFbuWJgshdCyJXTni5AcvbARZ8KIRGS5zRC1A4KOawa1wvaCECwIXC0ycsH1g== X-Received: by 2002:a17:902:f54e:b0:173:3c4d:2be4 with SMTP id h14-20020a170902f54e00b001733c4d2be4mr3793540plf.71.1661520838697; Fri, 26 Aug 2022 06:33:58 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:2a3c:773f:ac25:a127]) by smtp.gmail.com with UTF8SMTPSA id x196-20020a6286cd000000b00536816c0d4asm1757215pfd.147.2022.08.26.06.33.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 06:33:58 -0700 (PDT) Date: Fri, 26 Aug 2022 06:33:56 -0700 From: Matthias Kaehlcke To: Johan Hovold Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, Johan Hovold , Douglas Anderson , Krishna Kurapati , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH 2/2] clk: qcom: gcc-sc7280: Keep USB GDSC power domains on when USB wakeup is enabled Message-ID: References: <20220822115246.2.If09027f73daa6e1ed95f5eab02326b543c67132e@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 03:26:51PM +0200, Johan Hovold wrote: > On Fri, Aug 26, 2022 at 06:24:37AM -0700, Matthias Kaehlcke wrote: > > On Fri, Aug 26, 2022 at 06:19:37AM -0700, Matthias Kaehlcke wrote: > > > On Fri, Aug 26, 2022 at 03:12:05PM +0200, Johan Hovold wrote: > > > > On Fri, Aug 26, 2022 at 06:05:19AM -0700, Matthias Kaehlcke wrote: > > > > > On Thu, Aug 25, 2022 at 03:16:58PM -0700, Matthias Kaehlcke wrote: > > > > > > On Wed, Aug 24, 2022 at 10:47:44AM +0200, Johan Hovold wrote: > > > > > > > > > > > The wakeup setting doesn't seem to have anything to do with the genpd > > > > > > > issues on sc8280xp and the controller doesn't resume properly regardless > > > > > > > of whether the PHYs have been disabled or not during suspend unless the > > > > > > > PD is left on. > > > > > > > > > > > > I'm essentially seeing the same. USB is hosed after resume unless the PD > > > > > > is left on. > > > > > > > > > > > > On Chrome OS we currently work around that with a version of commit > > > > > > d9be8d5c5b03 ("usb: dwc3: qcom: Keep power domain on to retain controller > > > > > > status") which was reverted upstream. I'm not sure whether USB worked after > > > > > > resume before we enabled wakeup support. I would have sworn it did, but we > > > > > > landed an old version of the wakeup patches a long time ago, so my > > > > > > memory might be failing me. > > > > > > > > > > I need to remind myself that keeping the GDSC on is only needed when the PHYs > > > > > are kept on. The PHYs were always off before wakeup support was added, which > > > > > is why USB wasn't broken after suspend in the pre-wakeup days. > > > > > > > > Ok, so to be clear: if you disable wakeup with my patches applied so > > > > that the PD is actually turned off, USB still resumes with only > > > > GENPD_FLAG_ACTIVE_WAKEUP set? > > > > Actually without GENPD_FLAG_ACTIVE_WAKEUP > > Sure, that only comes into play with wakeup enabled. I assume you still > need it for USB wakeup to work? Yes, for USB wakeup to work either setting the above genpd flag or (better) the ALWAYS_ON flag of the GDSC is needed.