From: Thierry Reding <thierry.reding@gmail.com>
To: Petlozu Pravareshwar <petlozup@nvidia.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"dmitry.osipenko@collabora.com" <dmitry.osipenko@collabora.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"Kartik ." <kkartik@nvidia.com>,
"cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
Sandipan Patra <spatra@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc/tegra: pmc: Print reset info during probe
Date: Fri, 26 Aug 2022 18:03:07 +0200 [thread overview]
Message-ID: <Ywjuuw/rSRUSORFF@orome> (raw)
In-Reply-To: <DM6PR12MB316434A9BA61A01251E3BA3CB5739@DM6PR12MB3164.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On Wed, Aug 24, 2022 at 07:39:46PM +0000, Petlozu Pravareshwar wrote:
> >
> > On Wed, Aug 17, 2022 at 06:44:56PM +0000, Petlozu Pravareshwar wrote:
> > > During PMC probe, print previous reset related info such as reset
> > > reason and reset level.
> > >
> > > Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> > > ---
> > > drivers/soc/tegra/pmc.c | 27 +++++++++++++++++++++++++++
> > > 1 file changed, 27 insertions(+)
> >
> > We already expose this information in sysfs, why do we need to print it
> > during boot?
> >
> > Thierry
> There are some tests which would parse the boot log for this information.
> But I agree, since we are already providing this information through sysfs,
> there is no need to print it during boot.
It'd be a good idea to transition the tests to try and obtain this
information through sysfs first and if that fails they could fall back
to using the boot log. Although to be honest, I think we've supported
this sysfs interface for long enough that we probably don't have to
worry about a fallback.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-08-26 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 18:44 [PATCH] soc/tegra: pmc: Print reset info during probe Petlozu Pravareshwar
2022-08-18 15:14 ` Thierry Reding
2022-08-24 19:39 ` Petlozu Pravareshwar
2022-08-26 16:03 ` Thierry Reding [this message]
2022-09-09 14:16 ` Petlozu Pravareshwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywjuuw/rSRUSORFF@orome \
--to=thierry.reding@gmail.com \
--cc=cai.huoqing@linux.dev \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=petlozup@nvidia.com \
--cc=spatra@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox