From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8A4ECAAA6 for ; Fri, 26 Aug 2022 18:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344797AbiHZSJT (ORCPT ); Fri, 26 Aug 2022 14:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232069AbiHZSJR (ORCPT ); Fri, 26 Aug 2022 14:09:17 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96286B56E0; Fri, 26 Aug 2022 11:09:16 -0700 (PDT) Received: from zn.tnic (p200300ea971b98b8329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:98b8:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2692D1EC03EA; Fri, 26 Aug 2022 20:09:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1661537351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=iCRg1BZZBWD+TbCyuzPQlX9XHqNXqh9pUPyGuQmJ7bs=; b=c7+3bNPB8AcQzOC/SKx4n85TYarfRYJFQTtt3J7mFildxVA2qxwIa/+b6pSaWO7/ZJZ3ta HO1onnhJ2xADFE7ouivOeIxVRLmTE5YPy+ZAHSEFvxQpBDp2bXtJfiNkX/FbUIebi/2IlV NaNV9TNHJf3qgmygBzGERgmO2EQZF+A= Date: Fri, 26 Aug 2022 20:09:06 +0200 From: Borislav Petkov To: Dan Williams Cc: Jane Chu , "tony.luck@intel.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hch@lst.de" , "nvdimm@lists.linux.dev" Subject: Re: [PATCH v7] x86/mce: retrieve poison range from hardware Message-ID: References: <20220802195053.3882368-1-jane.chu@oracle.com> <630908d7e6937_259e5b29445@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <630908d7e6937_259e5b29445@dwillia2-xfh.jf.intel.com.notmuch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 10:54:31AM -0700, Dan Williams wrote: > How about: > > --- > > When memory poison consumption machine checks fire, > mce-notifier-handlers like nfit_handle_mce() record the impacted > physical address range. ... which is reported by the hardware in the MCi_MISC MSR. > The error information includes data about blast > radius, i.e. how many cachelines did the hardware determine are > impacted. Yap, nice. > A recent change, commit 7917f9cdb503 ("acpi/nfit: rely on > mce->misc to determine poison granularity"), updated nfit_handle_mce() > to stop hard coding the blast radius value of 1 cacheline, and instead > rely on the blast radius reported in 'struct mce' which can be up to 4K > (64 cachelines). > > It turns out that apei_mce_report_mem_error() had a similar problem in > that it hard coded a blast radius of 4K rather than checking the blast s/checking/reading/ > radius in the error information. Fix apei_mce_report_mem_error() to s/in/from/ > convey the proper poison granularity. > > --- Yap, that's a lot better. Thanks! -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette