From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52BDDECAAD4 for ; Thu, 1 Sep 2022 01:52:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232500AbiIABwx (ORCPT ); Wed, 31 Aug 2022 21:52:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232356AbiIABwu (ORCPT ); Wed, 31 Aug 2022 21:52:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EADFAEA328 for ; Wed, 31 Aug 2022 18:52:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9EBB6B823C5 for ; Thu, 1 Sep 2022 01:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BE5CC433C1; Thu, 1 Sep 2022 01:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661997167; bh=5OYhr0FmcZUpnR6J3fyt7LZstNlDXPjm3a0A16QDWu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tCpTgXf62rt1UA8F0L0XKAkFBFFD6y2DI+LNXSX8d0vFc/D4d+SGdDlGKlnSTwHQC xgzNzcu8NhSFhcefjhw1prLlpCuaWh6hxhzeG49iVw4Pjogiw8MRa5qb/9G7RJpqm2 p2fYJyZgAdIuJ7ShqkeuBbkz8OYTLOFv/hZzw5AxFLO1rAncVHFU00hjEbWLQuqGf7 Yr07nhPYY6F5ayCbrdOSFFknzKiWwZEUCGZB6IU/R6ArlMczyPZPXQn8TI/wJCn/Z0 toxylcHnehd+mFSWL4M0dPG7It7YOOb8h4isUbJoXCmrhDIZTDonsmRRHcT/xkJ3dk BYgHqczmBr7LA== Date: Thu, 1 Sep 2022 09:52:43 +0800 From: Tzung-Bi Shih To: Tim Van Patten Cc: rrangel@chromium.org, robbarnes@google.com, Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7] platform/chrome: cros_ec_lpc: Move host command to prepare/complete Message-ID: References: <20220823095915.v7.1.I55189adfdb8d025fc991a0fa820ec09078619b15@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 12:00:55PM -0600, Tim Van Patten wrote: > Hi, > > Friendly ping on this patch. We don't top-post on Linux kernel mailing lists. > On Tue, Aug 23, 2022 at 9:59 AM Tim Van Patten wrote: > > > > Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM > > .prepare() and cros_ec_lpc_complete() during .complete(). This moves the > > host command that the AP sends and allows the EC to log entry/exit of > > AP's suspend/resume more accurately. > > > > Signed-off-by: Tim Van Patten > > --- > > > > Changes in v7: > > - Rename "host event" to "host command" in title/description. > > > > Changes in v6: > > - Fully restore fixes from v3. > > > > Changes in v5: > > - Restore fixes from v3. > > > > Changes in v4: > > - Update title and description. > > > > Changes in v3: > > - Update cros_ec_lpc_suspend() to cros_ec_lpc_prepare() > > - Update cros_ec_lpc_resume() to cros_ec_lpc_complete() > > > > Changes in v2: > > - Include cros_ec_resume() return value in dev_info() output. > > - Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP. I don't buy-in the ideas from the discussion in v3[1]. Thus, I would defer to other reviewers/maintainers on the list to seek their suggestions. [1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220802113957.v3.1.I2c8c550183162e7594309b66d19af696b8d84552@changeid/