From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Raul Rangel <rrangel@chromium.org>
Cc: Tim Van Patten <timvp@google.com>,
Rob Barnes <robbarnes@google.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] platform/chrome: cros_ec_lpc: Move host command to prepare/complete
Date: Thu, 1 Sep 2022 10:44:21 +0800 [thread overview]
Message-ID: <YxAchTWf/99oaqix@google.com> (raw)
In-Reply-To: <CAHQZ30C4-B9ypnsdRqEZCJuZ7QVfaHXaK9f61vTtz_gcvC9EQQ@mail.gmail.com>
On Wed, Aug 31, 2022 at 08:21:23PM -0600, Raul Rangel wrote:
> On Wed, Aug 31, 2022 at 7:52 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > > On Tue, Aug 23, 2022 at 9:59 AM Tim Van Patten <timvp@google.com> wrote:
> > > >
> > > > Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM
> > > > .prepare() and cros_ec_lpc_complete() during .complete(). This moves the
> > > > host command that the AP sends and allows the EC to log entry/exit of
> > > > AP's suspend/resume more accurately.
> > > >
> > > > Signed-off-by: Tim Van Patten <timvp@google.com>
> > > > ---
> > > >
> > > > Changes in v7:
> > > > - Rename "host event" to "host command" in title/description.
> > > >
> > > > Changes in v6:
> > > > - Fully restore fixes from v3.
> > > >
> > > > Changes in v5:
> > > > - Restore fixes from v3.
> > > >
> > > > Changes in v4:
> > > > - Update title and description.
> > > >
> > > > Changes in v3:
> > > > - Update cros_ec_lpc_suspend() to cros_ec_lpc_prepare()
> > > > - Update cros_ec_lpc_resume() to cros_ec_lpc_complete()
> > > >
> > > > Changes in v2:
> > > > - Include cros_ec_resume() return value in dev_info() output.
> > > > - Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP.
> >
>
> > I don't buy-in the ideas from the discussion in v3[1]. Thus, I would defer
> > to other reviewers/maintainers on the list to seek their suggestions.
> >
> > [1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220802113957.v3.1.I2c8c550183162e7594309b66d19af696b8d84552@changeid/
>
> Just to clarify, you are opposed to printing the return code because
> `cros_ec_resume` currently always returns 0? Or is there another
> objection?
Yes. I'm not sure if always printing 0 is a good idea.
next prev parent reply other threads:[~2022-09-01 2:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 15:59 [PATCH v7] platform/chrome: cros_ec_lpc: Move host command to prepare/complete Tim Van Patten
2022-08-31 18:00 ` Tim Van Patten
2022-09-01 1:52 ` Tzung-Bi Shih
2022-09-01 2:21 ` Raul Rangel
2022-09-01 2:44 ` Tzung-Bi Shih [this message]
2022-09-01 15:50 ` Tim Van Patten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxAchTWf/99oaqix@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox