Re: [PATCH] USB: hcd: remove unused hcd_name variables

Alan Stern
2022-08-31T14:21:44Z

On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote:
> In the commit 10174220f55a ("usb: reduce kernel log spam on driver
> registration") a lot of unneeded kernel log messages were removed, but
> that caused a few build warnings to show up where the variable
> `hcd_name` was being set but never used anymore.
>
> Resolve this by just removing these variables as they are not needed
> anymore
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/usb/host/ehci-exynos.c | 1 -
> drivers/usb/host/ehci-platform.c | 2 --
> drivers/usb/host/ohci-platform.c | 2 --
> 3 files changed, 5 deletions(-)

This isn't enough, as you can see from this kernel test robot excerpt:

clang_recent_errors
|-- arm-s5pv210_defconfig
| |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
| `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name
|-- hexagon-randconfig-r024-20220830
| |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name
| |--
drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name
| `--
drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
|-- hexagon-randconfig-r036-20220830
| |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name
| |--
drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name
| |--
drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name
| |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name
| `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name

Yes, it has duplicates and your patch handles some of these. But there
are others that still need to be fixed. Also, this list is missing
ohci-pxa27x.c.

Alan Stern