From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DE2ECAAD1 for ; Thu, 1 Sep 2022 15:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233651AbiIAPF0 (ORCPT ); Thu, 1 Sep 2022 11:05:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233225AbiIAPFU (ORCPT ); Thu, 1 Sep 2022 11:05:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 376F220BE2 for ; Thu, 1 Sep 2022 08:05:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D06E161E2F for ; Thu, 1 Sep 2022 15:05:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD6BEC433C1; Thu, 1 Sep 2022 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662044717; bh=tWzWn0gW8BzXNqiAiZbScYJiINyRkPfjVCCo5/EfHrg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UhEgNktqoIw5GmTNE8yBGpp1wszbIa4x+a3aFYjP+gd6nej+A6+TWsoXrh9oFtdIS 35J83eHSg/SohtEw+IBHsQpt3uW4YCaUO1YSTe3DZjxK5XLIcKV6bY3Dk84tYKf6jj CKUY5GG6Zwr3qx5kmY1AVlcuGSAn+Q5fy3h98T94= Date: Thu, 1 Sep 2022 17:05:09 +0200 From: Greg KH To: Li Zhong Cc: linux-kernel@vger.kernel.org, rafael@kernel.org Subject: Re: [PATCH v1] drivers/base/auxiliary: check return value of strrchr() Message-ID: References: <20220828204040.1953493-1-floridsleeves@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220828204040.1953493-1-floridsleeves@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 28, 2022 at 01:40:40PM -0700, Li Zhong wrote: > From: lily > > The return value of strrchr() could be NULL, which will cause invalid > offset in (int)(p - name). So we check it here. > > Signed-off-by: Li Zhong > --- > drivers/base/auxiliary.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > index 8c5e65930617..7ac23be47e1f 100644 > --- a/drivers/base/auxiliary.c > +++ b/drivers/base/auxiliary.c > @@ -191,7 +191,8 @@ static int auxiliary_uevent(struct device *dev, struct kobj_uevent_env *env) > > name = dev_name(dev); > p = strrchr(name, '.'); > - > + if (!p) > + return -EINVAL; > return add_uevent_var(env, "MODALIAS=%s%.*s", AUXILIARY_MODULE_PREFIX, > (int)(p - name), name); > } > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/SubmittingPatches for how to do this correctly. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot