From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BF3ECAAD1 for ; Thu, 1 Sep 2022 15:45:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234483AbiIAPpy (ORCPT ); Thu, 1 Sep 2022 11:45:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234500AbiIAPpi (ORCPT ); Thu, 1 Sep 2022 11:45:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F41E29CBF for ; Thu, 1 Sep 2022 08:45:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A62CAB82794 for ; Thu, 1 Sep 2022 15:45:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7C31C433C1; Thu, 1 Sep 2022 15:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662047134; bh=HukMI1R+gL6RpQPnp6lX3XucBqqg+Tq8EFaCmFRJVnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1i00LRzgfsCsvonZUn94TKBhCXOScNzMjJcKyuDQjtik7jHIl+TzAHO4aAYoq+1IM YOIGpUIAn34uGJQrliLTGLBOG/PIu00KAwkSsk7Eso6d/uttDoJWscCvQGwglL3Ihu vIT4q4Dt7dV1sTDIITm7NCvo0l80d/MK0Q4IO36U= Date: Thu, 1 Sep 2022 17:45:31 +0200 From: Greg Kroah-Hartman To: Alexander Baehr Cc: Sudip Mukherjee , LKML Subject: Re: [PATCH 2/2] Add parport support for Asix device 99100 Message-ID: References: <20220806113124.608017725@osadl.org> <20220806113334.349537884@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220806113334.349537884@osadl.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 06, 2022 at 01:31:26PM +0200, Alexander Baehr wrote: > For some reason, Asix decided to produce a parallel port that is fully > compatible with Netmos device 9900, but named it 99100. It obviously has > another vendor ID, but the device ID is the same. This patch adds the > required settings and was successfully tested with the Asix device. > > Signed-off-by: Alexander Baehr > --- > drivers/parport/parport_pc.c | 4 ++++ > include/linux/pci_ids.h | 3 +++ > 2 files changed, 7 insertions(+) > > Index: linux/drivers/parport/parport_pc.c > =================================================================== > --- linux.orig/drivers/parport/parport_pc.c > +++ linux/drivers/parport/parport_pc.c > @@ -2612,6 +2612,7 @@ enum parport_pc_pci_cards { > netmos_9815, > netmos_9901, > netmos_9865, > + asix_ax99100, > quatech_sppxp100, > wch_ch382l, > }; > @@ -2766,6 +2767,9 @@ static const struct pci_device_id parpor > 0xA000, 0x1000, 0, 0, netmos_9865 }, > { PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9865, > 0xA000, 0x2000, 0, 0, netmos_9865 }, > + /* Asix AX99100 Parallel port PCIExpressCard */ > + { PCI_VENDOR_ID_ASIX, PCI_DEVICE_ID_AX99100, > + 0xA000, 0x2000, 0, 0, netmos_9900 }, > /* Quatech SPPXP-100 Parallel port PCI ExpressCard */ > { PCI_VENDOR_ID_QUATECH, PCI_DEVICE_ID_QUATECH_SPPXP_100, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, quatech_sppxp100 }, > Index: linux/include/linux/pci_ids.h > =================================================================== > --- linux.orig/include/linux/pci_ids.h > +++ linux/include/linux/pci_ids.h > @@ -3108,4 +3108,7 @@ > > #define PCI_VENDOR_ID_NCUBE 0x10ff > > +#define PCI_VENDOR_ID_ASIX 0x125b > +#define PCI_DEVICE_ID_AX99100 0x9100 Please read the top of this file for why to not add new ids to it. thanks, greg k-h