Re: [PATCH v3 07/19] hwmon: (mr75203) enable polling for all VM channels

Andy Shevchenko
2022-08-31T11:21:58Z

On Tue, Aug 30, 2022 at 07:22:00PM +0000, Eliav Farber wrote:
> Configure ip-polling register to enable polling for all voltage monitor
> channels.
> This enables reading the voltage values for all inputs other than just
> input 0.

...

> + val = GENMASK(pvt->c_num - 1, 0) | VM_CH_INIT |

I believe in this case (BIT(pvt->c_num) - 1) is better, but not sure
if c_num can be 32.

> + IP_POLL << SDIF_ADDR_SFT |
> + SDIF_WRN_W | SDIF_PROG;

--
With Best Regards,
Andy Shevchenko