From: Mike Snitzer <snitzer@redhat.com>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: agk@redhat.com, snitzer@kernel.org, axboe@kernel.dk,
damien.lemoal@opensource.wdc.com, hch@lst.de, bvanassche@acm.org,
pankydev8@gmail.com, Johannes.Thumshirn@wdc.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, dm-devel@redhat.com,
gost.dev@samsung.com, jaegeuk@kernel.org,
matias.bjorling@wdc.com
Subject: Re: [PATCH v12 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices
Date: Thu, 1 Sep 2022 20:18:20 -0400 [thread overview]
Message-ID: <YxFLzHoYF7damFip@redhat.com> (raw)
In-Reply-To: <20220823121859.163903-12-p.raghav@samsung.com>
On Tue, Aug 23 2022 at 8:18P -0400,
Pankaj Raghav <p.raghav@samsung.com> wrote:
> dm_zone_endio() updates the bi_sector of orig bio for zoned devices that
> uses either native append or append emulation, and it is called before the
> endio of the target. But target endio can still update the clone bio
> after dm_zone_endio is called, thereby, the orig bio does not contain
> the updated information anymore.
>
> Currently, this is not a problem as the targets that support zoned devices
> such as dm-zoned, dm-linear, and dm-crypt do not have an endio function,
> and even if they do (such as dm-flakey), they don't modify the
> bio->bi_iter.bi_sector of the cloned bio that is used to update the
> orig_bio's bi_sector in dm_zone_endio function.
>
> This is a prep patch for the new dm-po2zone target as it modifies
> bi_sector in the endio callback.
>
> Call dm_zone_endio for zoned devices after calling the target's endio
> function.
>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Great patch header, explains the situation nicely.
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
next prev parent reply other threads:[~2022-09-02 0:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220823121901eucas1p1d8ec2e0d3d6be63b9d4338f70dd717fe@eucas1p1.samsung.com>
2022-08-23 12:18 ` [PATCH v12 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
2022-08-23 12:18 ` [PATCH v12 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
2022-08-23 12:18 ` [PATCH v12 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} helpers in blkdev.h Pankaj Raghav
2022-08-25 21:45 ` Bart Van Assche
2022-08-23 12:18 ` [PATCH v12 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-08-26 20:06 ` Jonathan Derrick
2022-08-26 20:09 ` Jonathan Derrick
2022-08-23 12:18 ` [PATCH v12 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
2022-08-23 12:18 ` [PATCH v12 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-08-25 21:46 ` Bart Van Assche
2022-08-23 12:18 ` [PATCH v12 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-25 21:49 ` Bart Van Assche
2022-08-23 12:18 ` [PATCH v12 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
2022-08-23 12:18 ` [PATCH v12 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-08-25 21:50 ` [dm-devel] " Bart Van Assche
2022-09-02 0:16 ` Mike Snitzer
2022-08-23 12:18 ` [PATCH v12 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-08-25 21:53 ` Bart Van Assche
2022-09-02 0:16 ` Mike Snitzer
2022-08-23 12:18 ` [PATCH v12 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-02 0:17 ` Mike Snitzer
2022-08-23 12:18 ` [PATCH v12 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
2022-09-02 0:18 ` Mike Snitzer [this message]
2022-08-23 12:18 ` [PATCH v12 12/13] dm: introduce DM_EMULATED_ZONES target type Pankaj Raghav
2022-09-02 0:28 ` Mike Snitzer
2022-09-02 12:02 ` Pankaj Raghav
2022-09-02 18:43 ` Mike Snitzer
2022-08-23 12:18 ` [PATCH v12 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-30 2:52 ` Shinichiro Kawasaki
2022-08-30 10:03 ` Pankaj Raghav
2022-09-02 12:05 ` Pankaj Raghav
2022-09-02 20:55 ` Mike Snitzer
2022-09-02 21:07 ` Mike Snitzer
2022-09-05 12:57 ` Pankaj Raghav
2022-09-05 12:48 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxFLzHoYF7damFip@redhat.com \
--to=snitzer@redhat.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matias.bjorling@wdc.com \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox