public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Saravana Kannan <saravanak@google.com>
Subject: Re: [GIT PULL] Driver core fixes for 6.0-rc4
Date: Sat, 3 Sep 2022 08:42:35 +0200	[thread overview]
Message-ID: <YxL3W3Sb0AMMt01T@kroah.com> (raw)
In-Reply-To: <CAHk-=whnNO4T9PHNC1DT35sROGNK_geKL0Q_EjZH=0sLoACPHw@mail.gmail.com>

On Fri, Sep 02, 2022 at 11:02:00AM -0700, Linus Torvalds wrote:
> On Fri, Sep 2, 2022 at 8:31 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-6.0-rc4
> 
> Entirely unrelated to this pull request, but since the diffstat made
> that "drivers/base/dd.c" file stand out, I tried to look at what the
> history of that odd name is.
> 
> And it's not obvious to me.
> 
> Very strange filename. Should it perhaps be named "device.c" or
> "probe.c" or something more descriptive?
> 
> Not a huge deal, more of a passing thought inspired by that diffstat.

I think Pat named it and I always think of it as "device vs. driver".c
as it handles all of the device and driver interactions between binding
and unbinding and other fun logic there.  I'm all for a new name if
anyone has any ideas, "probe.c" is sane, but it also handles disconnect
logic.  "core.c" already has lots of device functions, so renaming it to
"device.c" would be confusing.  I don't know...

Yeah, in digging, Pat did this in commit 07e4a3e27fe4 ("[PATCH] Move
device/driver code to drivers/base/dd.c") way back in 2005 to get code
out of drivers/base/bus.c.

Naming is hard :)

greg k-h

  reply	other threads:[~2022-09-03  6:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 15:31 [GIT PULL] Driver core fixes for 6.0-rc4 Greg KH
2022-09-02 18:02 ` Linus Torvalds
2022-09-03  6:42   ` Greg KH [this message]
2022-09-02 18:30 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxL3W3Sb0AMMt01T@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saravanak@google.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox