From: Jules Irenge <jbi.octave@gmail.com>
To: ast@kernel.org
Cc: john.fastabend@gmail.com, andrii@kernel.org,
daniel@iogearbox.net, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, martin.lau@linux.dev,
jbi.octave@gmail.com
Subject: [PATCH 1/2] bpf: Fix warning of Using plain integer as NULL pointer
Date: Sat, 3 Sep 2022 19:56:06 +0100 [thread overview]
Message-ID: <YxOjRm5xqL68JVnt@playground> (raw)
This patch fixes a warning generated by Sparse
"Using plain integer as NULL pointer"
by replacing the offending 0 by NULL.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
kernel/bpf/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 27760627370d..427b7e3829e0 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -598,7 +598,7 @@ void bpf_map_free_kptrs(struct bpf_map *map, void *map_value)
if (off_desc->type == BPF_KPTR_UNREF) {
u64 *p = (u64 *)btf_id_ptr;
- WRITE_ONCE(p, 0);
+ WRITE_ONCE(p, NULL);
continue;
}
old_ptr = xchg(btf_id_ptr, 0);
--
2.35.1
next reply other threads:[~2022-09-03 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 18:56 Jules Irenge [this message]
2022-09-03 19:10 ` [PATCH 1/2] bpf: Fix warning of Using plain integer as NULL pointer Kumar Kartikeya Dwivedi
2022-09-04 10:36 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxOjRm5xqL68JVnt@playground \
--to=jbi.octave@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox