From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554F4ECAAD5 for ; Mon, 5 Sep 2022 08:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237840AbiIEIaV (ORCPT ); Mon, 5 Sep 2022 04:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237838AbiIEI3w (ORCPT ); Mon, 5 Sep 2022 04:29:52 -0400 Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2E5D4E864; Mon, 5 Sep 2022 01:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1662366477; x=1693902477; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tRFYGv84M2LaryAxLO+4jpAXwsqd1ialVQ9dqVpUd64=; b=CvZLYj8XOiPcjtvbgFgaVsr2sG4JxTIlPlDCniQR4i4dZz91QlG2VW/6 Cme95nKkOkLlhGtu6zqjXE/6WQxl2CZlOwyYUrmY1OGBQlauRdV+6bOtj U+Tubl0eu6xR8Mm1LTlbkCzgh5M2B9OZXozkrRz4fM6cqQPBVaSEG+Kwc jMdcTF16H9JpVE+XtBdyTQA0oN4CoomH8ZPhraKulFHxn3M9c37RrGaLF 4oViz2HZsFrJQkXamV54uFzuPJ7rFSEdvWSmoTjq84MnCfXS2UEDODyKv yC3rqY5EKsR7JuCWnGZqviiPS71I8rL1i1w8d9Zj0ErW6GagltDSUrzWg Q==; Date: Mon, 5 Sep 2022 10:27:51 +0200 From: Vincent Whitchurch To: Jonathan Cameron CC: Andy Shevchenko , kernel , Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List Subject: Re: [PATCH v2 1/5] iio: adc: mcp320x: use callbacks for RX conversion Message-ID: References: <20220831100506.3368103-1-vincent.whitchurch@axis.com> <20220831100506.3368103-2-vincent.whitchurch@axis.com> <20220904171559.1bf77d42@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220904171559.1bf77d42@jic23-huawei> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 04, 2022 at 06:15:59PM +0200, Jonathan Cameron wrote: > I'm not keen to push unrelated work onto someone doing good stuff > on a driver, but in this particular case it does seem reasonable to > tidy all this up given you are moving the code anyway. Well, even the moving of the code is unrelated to the original goal of adding triggered buffered support and isn't necessary for that. The moving of the code was only to eliminate the use of the "device_index", which was already used in the existing code. I'm of course happy to fix problems with the code I'm actually adding, but it seems to me that it would really be simpler for everyone if the trivial comments (especially the purely cosmetic ones) on the existing, unrelated code would be fixed by the people with the opinions about how the existing code should look like. I don't have any special ability to test the dozen different chips this driver supports, so having me do it by proxy seems rather suboptimal. I can only run it in roadtest, which anyone can do with the following commands (against v5.19 due to the regressions in mainline I mentioned in my other email), without special hardware: git checkout v5.19 git remote add vwax https://github.com/vwax/linux.git git fetch vwax git archive vwax/roadtest/mcp320x tools/testing/roadtest | tar xf - make -C tools/testing/roadtest/ -j24 OPTS="-v -k 'mcp and not trigger'"