From: Ingo Molnar <mingo@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] x86/config: Make the x86 defconfigs a bit more usable
Date: Mon, 5 Sep 2022 11:54:20 +0200 [thread overview]
Message-ID: <YxXHTMl/7PhVRSA9@gmail.com> (raw)
In-Reply-To: <CAK7LNATnGO3LHZ7VvJRziDqz50gRq7MUJPOJLMfcv=pCiA=-mg@mail.gmail.com>
* Masahiro Yamada <masahiroy@kernel.org> wrote:
> On Sun, Sep 4, 2022 at 6:48 PM Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
> > * Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > > > Unfortunately, even without the ARCH=i386 'make savedefconfig' doesn't
> > > > seem to be doing the right thing & is dropping the '# CONFIG_64BIT is
> > > > not set' line:
> > >
> > >
> > > Oh, really?
> > >
> > > Without ARCH=i386, it works correctly for me.
> > >
> > >
> > >
> > > masahiro@zoe:~/ref/linux$ make i386_defconfig savedefconfig
> > > #
> > > # No change to .config
> > > #
> > > masahiro@zoe:~/ref/linux$ grep CONFIG_64BIT defconfig
> > > # CONFIG_64BIT is not set
> >
> > Yeah, so why do these two seemingly identical commands produce two
> > different .config's:
> >
> > $ make ARCH=i386 defconfig
> > *** Default configuration is based on 'i386_defconfig'
> >
> > $ make i386_defconfig
> >
> > ?
>
>
>
> As Nathan explained in this thread,
> the prompt of CONFIG_64BIT is hidden
> when ARCH=i386.
Yeah, so my 'why' question was more about why we'd tolerate the UI
inconsistency in seemingly similar commands generating subtly different
.config's.
In other words, what should we modify in this Kconfig block, or in other
parts of the kernel:
> config 64BIT
> bool "64-bit kernel" if "$(ARCH)" = "x86"
> default "$(ARCH)" != "i386"
> help
> Say yes to build a 64-bit kernel - formerly known as x86_64
> Say no to build a 32-bit kernel - formerly known as i386
... to not have this Kconfig UI quirk/bug/inconsistency?
I hope we agree that the status quo is not ideal.
Thanks,
Ingo
next prev parent reply other threads:[~2022-09-05 9:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 11:11 [GIT PULL] locking changes for v5.18 Ingo Molnar
2022-03-22 22:05 ` Linus Torvalds
2022-03-22 22:19 ` Borislav Petkov
2022-03-22 22:58 ` Linus Torvalds
2022-03-23 7:11 ` Sebastian Andrzej Siewior
2022-03-23 11:09 ` [PATCH] locking/local_lock: Pretend to use the per-CPU variable if not needed Sebastian Andrzej Siewior
2022-03-23 17:17 ` Linus Torvalds
2022-03-24 17:39 ` [PATCH 0/3] Remove volatile from arch_raw_cpu_ptr() and revert the hacks Sebastian Andrzej Siewior
2022-03-24 17:39 ` [PATCH 1/3] x86/percpu: Remove volatile from arch_raw_cpu_ptr() Sebastian Andrzej Siewior
2022-03-24 17:39 ` [PATCH 2/3] Revert "locking/local_lock: Make the empty local_lock_*() function a macro." Sebastian Andrzej Siewior
2022-03-24 17:39 ` [PATCH 3/3] Revert "mm/page_alloc: mark pagesets as __maybe_unused" Sebastian Andrzej Siewior
2022-03-24 18:28 ` [PATCH 0/3] Remove volatile from arch_raw_cpu_ptr() and revert the hacks Linus Torvalds
2022-03-28 13:55 ` Peter Zijlstra
2022-03-28 14:59 ` Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 " Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 1/3] x86/percpu: Remove volatile from arch_raw_cpu_ptr() Sebastian Andrzej Siewior
2022-04-05 8:28 ` [tip: locking/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 2/3] Revert "locking/local_lock: Make the empty local_lock_*() function a macro." Sebastian Andrzej Siewior
2022-04-05 8:28 ` [tip: locking/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 3/3] Revert "mm/page_alloc: mark pagesets as __maybe_unused" Sebastian Andrzej Siewior
2022-04-05 8:28 ` [tip: locking/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2022-03-23 11:21 ` [PATCH] x86/defconfig: Enable WERROR Borislav Petkov
2022-03-23 17:19 ` Linus Torvalds
2022-03-23 17:33 ` Borislav Petkov
2022-03-24 8:31 ` [PATCH] x86/config: Make the x86 defconfigs a bit more usable Ingo Molnar
2022-03-24 9:12 ` David Laight
2022-03-24 15:47 ` Nathan Chancellor
2022-03-25 11:52 ` Andy Shevchenko
2022-03-27 19:04 ` Ingo Molnar
2022-03-27 19:03 ` Ingo Molnar
2022-03-28 15:41 ` Nathan Chancellor
2022-09-02 8:50 ` Ingo Molnar
2022-09-02 9:18 ` Masahiro Yamada
2022-09-04 9:48 ` Ingo Molnar
2022-09-05 2:16 ` Masahiro Yamada
2022-09-05 9:54 ` Ingo Molnar [this message]
[not found] ` <CAK7LNAQyiNpbLuVjjQ8-GOQECtfQZqsNS8xH0E2ZkLAHYtXt7A@mail.gmail.com>
2022-09-10 17:28 ` Linus Torvalds
2022-03-24 8:16 ` [tip: x86/urgent] x86/defconfig: Enable WERROR tip-bot2 for Borislav Petkov
2022-03-25 11:41 ` [GIT PULL] locking changes for v5.18 Andy Shevchenko
2022-03-25 12:23 ` Peter Zijlstra
2022-03-25 13:06 ` Andy Shevchenko
2022-03-25 17:29 ` Linus Torvalds
2022-03-25 17:53 ` Andy Shevchenko
2022-03-22 22:38 ` Peter Zijlstra
2022-03-22 23:26 ` Linus Torvalds
2022-03-24 8:40 ` Ingo Molnar
2022-03-24 10:19 ` Borislav Petkov
2022-03-24 23:19 ` Nick Desaulniers
2022-03-22 23:27 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxXHTMl/7PhVRSA9@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox