From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, sanju.mehta@amd.com,
mario.limonciello@amd.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Resume PCIe bridges after switch is found on AMD USB4 controller
Date: Mon, 5 Sep 2022 18:34:55 +0300 [thread overview]
Message-ID: <YxYXH5dqKqPANeVX@black.fi.intel.com> (raw)
In-Reply-To: <CAAd53p6bSmTPavjA0v6tybc6=HrwiDn0JGzXwVOG_m5EVw1p1w@mail.gmail.com>
On Mon, Sep 05, 2022 at 11:21:36PM +0800, Kai-Heng Feng wrote:
> > Hmm, so you see the actual hotplug but the tunneled PCIe link may not be
> > detected? Does the PCIe "Card Present" (or Data Link Layer Active)
> > status change at all or is it always 0?
>
> It changes only after tb_switch_add() is called.
I doubt tb_switch_add() does anything but instead it is the established
PCIe tunnel that then shows up as it toggles the Card Present bit or so.
But that should also trigger PME if the root port is in D3 so you should
see this wake if everything works accordingly (unless I'm missing
something).
So if you do this:
1. Boot the system up, nothing connected
2. Plug in the TBT/USB4 device but do not authorize the PCIe tunnel
3. Wait for the TBT/USB4 domain to enter sleep (runtime suspend)
4. Authorize the PCIe tunnel
# echo 1 > .../authorized
The established PCIe tunnel should trigger PME and the root port then
should be able to detect the PCIe link. Can you add full dmesg with
"thunderbolt.dyndbg=+p" in the command line to the bug?
next prev parent reply other threads:[~2022-09-05 15:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 6:56 [PATCH] thunderbolt: Resume PCIe bridges after switch is found on AMD USB4 controller Kai-Heng Feng
2022-09-05 7:07 ` Mika Westerberg
2022-09-05 7:26 ` Kai-Heng Feng
2022-09-05 7:50 ` Mika Westerberg
2022-09-05 13:18 ` Mika Westerberg
2022-09-05 15:24 ` Kai-Heng Feng
2022-09-05 15:36 ` Mika Westerberg
2022-09-05 15:21 ` Kai-Heng Feng
2022-09-05 15:34 ` Mika Westerberg [this message]
2022-09-06 12:57 ` Kai-Heng Feng
2022-09-06 13:37 ` Mika Westerberg
2022-09-06 14:29 ` Kai-Heng Feng
2022-09-06 14:59 ` Mika Westerberg
2022-09-06 15:22 ` Mika Westerberg
2022-09-05 7:29 ` Greg KH
2022-09-07 16:30 ` Limonciello, Mario
2022-09-08 14:02 ` Kai-Heng Feng
2022-09-08 15:22 ` Limonciello, Mario
2022-09-12 7:35 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxYXH5dqKqPANeVX@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=sanju.mehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox