From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B9CC38145 for ; Tue, 6 Sep 2022 06:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238634AbiIFGqd (ORCPT ); Tue, 6 Sep 2022 02:46:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238620AbiIFGq1 (ORCPT ); Tue, 6 Sep 2022 02:46:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EC1D6C119; Mon, 5 Sep 2022 23:46:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 04399B81627; Tue, 6 Sep 2022 06:46:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B63DC433D6; Tue, 6 Sep 2022 06:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662446783; bh=rim4Ie1LmvHVmgE+dDKh4b6m5q06SFqtC7hxw1FSd5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jhXwK+Cxqw6Z09Oh4njgUY1Qt8lHhpqGmS/cz7jecWZf/Zp1ev0H7LkW3sy3mGGmy nzV1+AvPbCp6p63DEbeIiBgD2uhwrLXyMVQWTPY3NZE2twWyUkeimTa9Ptspb1EU9X B+B4fzVX6Smd4XIVIvlk9mlgnjflkdfSk4s/aQlA= Date: Tue, 6 Sep 2022 08:46:21 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: Sasha Levin , stable-commits@vger.kernel.org, johan+linaro@kernel.org, Felipe Balbi , linux-kernel@vger.kernel.org Subject: Re: Patch "usb: dwc3: qcom: fix peripheral and OTG suspend" has been added to the 5.19-stable tree Message-ID: References: <20220905125309.1037700-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 07:48:22AM +0200, Johan Hovold wrote: > On Mon, Sep 05, 2022 at 01:00:59PM -0400, Sasha Levin wrote: > > On Mon, Sep 05, 2022 at 05:00:10PM +0200, Johan Hovold wrote: > > >On Mon, Sep 05, 2022 at 09:36:07AM -0400, Sasha Levin wrote: > > >> On Mon, Sep 05, 2022 at 03:23:13PM +0200, Johan Hovold wrote: > > >> >On Mon, Sep 05, 2022 at 09:17:41AM -0400, Sasha Levin wrote: > > >> >> On Mon, Sep 05, 2022 at 03:13:09PM +0200, Johan Hovold wrote: > > >> >> >On Mon, Sep 05, 2022 at 09:04:44AM -0400, Sasha Levin wrote: > > >> >> >> On Mon, Sep 05, 2022 at 02:58:31PM +0200, Johan Hovold wrote: > > >> >> >> >On Mon, Sep 05, 2022 at 08:53:09AM -0400, Sasha Levin wrote: > > >> >> >> >> Fixes: 6895ea55c385 ("usb: dwc3: qcom: Configure wakeup interrupts during suspend") > > >> >> >> > > > >> >> >> >This commit doesn't exist in 5.19 (and earlier trees), shouldn't your > > >> >> >> >scripts check for that? > > >> >> >> > > >> >> >> They do - it was backported to 5.19. > > >> >> > > > >> >> >What?! Why on earth would 6895ea55c385 ("usb: dwc3: qcom: Configure > > >> >> >wakeup interrupts during suspend") be backported to stable? > > >> >> > > > >> >> >Please drop that patch instead. It's essentially a new feature and is in > > >> >> >any case in no way stable material. > > >> >> > > >> >> Right, it was picked up as a dependency of a872ab303d5d ("usb: dwc3: qcom: fix use-after-free on runtime-PM wakeup") > > >> > > > >> >That's wrong too, it's not a dependency for that fix. > > >> > > >> Right, it may not strictly be one, but we're trying to bring in > > >> dependencies as is without modifying the patch is it's far less error > > >> prone, and keeps future backports easy, as long as backporting those > > >> isn't riskier. > > > > > >It should only be some context that have changed. Backporting a known > > >broken and non-trivial feature patch for that can't be right. It is > > >certainly riskier. > > > > > >> In this case, if I were to drop a872ab303d5d I'd also need to drop: > > >> > > >> a872ab303d5d ("usb: dwc3: qcom: fix use-after-free on runtime-PM wakeup") > > >> 6498a96c8c9c ("usb: dwc3: qcom: fix runtime PM wakeup") > > >> > > >> >So does this mean you're dropping the patches that should not be > > >> >backported? > > >> > > >> Having said the above, at the end it's your patches and your call, let > > >> me know if you're okay with dropping a872ab303d5d, a872ab303d5d, and > > > > > >You mentioned a872ab303d5d twice here. > > > > > >> 6498a96c8c9c from all trees and I'll do that. > > > > > >This one didn't have a CC stable tag so not sure why you're backporting > > >that one either. > > > > > >Just pick > > > > > > a872ab303d5d ("usb: dwc3: qcom: fix use-after-free on runtime-PM wakeup") > > > > > >which was the only patch I had marked for stable and fix up the trivial > > >context change (an unrelated function has been added after the new > > >helper in mainline). > > > > Okay, this should be done. Please take a look at the queue to confirm. > > I only checked the pending-5.19 branch, but that one still has > > 360e8230516d ("usb: dwc3: qcom: Add helper functions to enable,disable wake irqs") > > which should be dropped as well. Now dropped. It was needed for a different dwc3 patch, so I dropped that too and will figure them out later today... thanks, greg k-h