public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>,
	Andrew Halaney <ahalaney@redhat.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH stable-5.15 1/3] usb: dwc3: fix PHY disable sequence
Date: Tue, 6 Sep 2022 14:25:25 +0200	[thread overview]
Message-ID: <Yxc8NclTP8hwmQG9@hovoldconsulting.com> (raw)
In-Reply-To: <Yxc6GMzOrz1k1c2D@kroah.com>

On Tue, Sep 06, 2022 at 02:16:24PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 06, 2022 at 02:07:00PM +0200, Johan Hovold wrote:
> > From: Johan Hovold <johan+linaro@kernel.org>
> > 
> > commit d2ac7bef95c9ead307801ccb6cb6dfbeb14247bf upstream.
> > 
> > Generic PHYs must be powered-off before they can be tore down.
> > 
> > Similarly, suspending legacy PHYs after having powered them off makes no
> > sense.
> > 
> > Fix the dwc3_core_exit() (e.g. called during suspend) and open-coded
> > dwc3_probe() error-path sequences that got this wrong.
> > 
> > Note that this makes dwc3_core_exit() match the dwc3_core_init() error
> > path with respect to powering off the PHYs.
> > 
> > Fixes: 03c1fd622f72 ("usb: dwc3: core: add phy cleanup for probe error handling")
> > Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> > Cc: stable@vger.kernel.org      # 4.8
> > Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > Link: https://lore.kernel.org/r/20220804151001.23612-2-johan+linaro@kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > [ johan: adjust context to 5.15 ]
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> >  drivers/usb/dwc3/core.c | 19 ++++++++++---------
> >  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> This one did not apply to 4.9.y, 4.14.y, or 4.19.y :(

Perhaps someone who cares about these old trees can do the backports.
Should be as trivial. Can't be the patch submitters responsibility to
maintain 8 stable trees.

Johan

  reply	other threads:[~2022-09-06 12:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 12:06 [PATCH stable-5.15 0/3] usb: dwc3: 5.15 backports Johan Hovold
2022-09-06 12:07 ` [PATCH stable-5.15 1/3] usb: dwc3: fix PHY disable sequence Johan Hovold
2022-09-06 12:16   ` Greg Kroah-Hartman
2022-09-06 12:25     ` Johan Hovold [this message]
2022-09-06 13:14       ` Greg Kroah-Hartman
2022-09-06 12:07 ` [PATCH stable-5.15 2/3] usb: dwc3: qcom: fix use-after-free on runtime-PM wakeup Johan Hovold
2022-09-06 12:15   ` Greg Kroah-Hartman
2022-09-06 12:07 ` [PATCH stable-5.15 3/3] usb: dwc3: disable USB core PHY management Johan Hovold
2022-09-06 12:18   ` Greg Kroah-Hartman
2022-09-06 12:27     ` Johan Hovold
2022-10-18 15:27   ` [PATCH stable-5.15 3/3] " Stefan Agner
2022-10-19  8:59     ` Johan Hovold
2022-10-20 22:06       ` Stefan Agner
2022-10-21  6:54         ` Johan Hovold
2022-10-26 13:11           ` Stefan Agner
2022-10-27 12:45             ` Johan Hovold
2022-11-03 14:49               ` Johan Hovold
2022-11-03 15:18                 ` Marek Szyprowski
2022-11-03 15:29                   ` Johan Hovold
2022-10-28 13:46     ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yxc8NclTP8hwmQG9@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=ahalaney@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan+linaro@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mka@chromium.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox