Re: [PATCH stable-5.15 1/3] usb: dwc3: fix PHY disable sequence

Greg Kroah-Hartman
2022-09-06T13:14:37Z

On Tue, Sep 06, 2022 at 02:25:25PM +0200, Johan Hovold wrote:
> On Tue, Sep 06, 2022 at 02:16:24PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Sep 06, 2022 at 02:07:00PM +0200, Johan Hovold wrote:
> > > From: Johan Hovold <johan+linaro@kernel.org>
> > >
> > > commit d2ac7bef95c9ead307801ccb6cb6dfbeb14247bf upstream.
> > >
> > > Generic PHYs must be powered-off before they can be tore down.
> > >
> > > Similarly, suspending legacy PHYs after having powered them off makes no
> > > sense.
> > >
> > > Fix the dwc3_core_exit() (e.g. called during suspend) and open-coded
> > > dwc3_probe() error-path sequences that got this wrong.
> > >
> > > Note that this makes dwc3_core_exit() match the dwc3_core_init() error
> > > path with respect to powering off the PHYs.
> > >
> > > Fixes: 03c1fd622f72 ("usb: dwc3: core: add phy cleanup for probe error handling")
> > > Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> > > Cc: stable@vger.kernel.org # 4.8
> > > Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
> > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > Link: https://lore.kernel.org/r/20220804151001.23612-2-johan+linaro@kernel.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > [ johan: adjust context to 5.15 ]
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > ---
> > > drivers/usb/dwc3/core.c | 19 ++++++++++---------
> > > 1 file changed, 10 insertions(+), 9 deletions(-)
> >
> > This one did not apply to 4.9.y, 4.14.y, or 4.19.y :(
>
> Perhaps someone who cares about these old trees can do the backports.
> Should be as trivial. Can't be the patch submitters responsibility to
> maintain 8 stable trees.

I agree! :)