public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
Cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, lkp@intel.com
Subject: Re: [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix dependency issues in building the pci1xxxx's aux bus driver.
Date: Tue, 6 Sep 2022 13:05:23 +0200	[thread overview]
Message-ID: <Yxcpc7ao10kytxbV@kroah.com> (raw)
In-Reply-To: <20220906103658.681751-1-kumaravel.thiagarajan@microchip.com>

On Tue, Sep 06, 2022 at 04:06:58PM +0530, Kumaravel Thiagarajan wrote:
> build errors and warnings listed below and reported by kernel
> test robot <lkp@intel.com> on the char-misc-next branch are
> fixed in this add-on patch.
> 
> errors:
> ERROR: modpost: "auxiliary_device_init"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!

These lines should now be wrapped, it's ok to have long lines that show
the error messages.

> ERROR: modpost: "__auxiliary_device_add"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!
> ERROR: modpost: "auxiliary_driver_unregister"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> ERROR: modpost: "__auxiliary_driver_register"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.o:
>  in function `gp_aux_bus_probe.part.0':
> mchp_pci1xxxx_gp.c:(.text+0x342): undefined reference to
>  `auxiliary_device_init'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x392):
>  undefined reference to `__auxiliary_device_add'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x5c2):
>  undefined reference to `auxiliary_device_init'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x612):
>  undefined reference to `__auxiliary_device_add'
> ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.o:
>  in function `pci1xxxx_gpio_driver_init':
>  mchp_pci1xxxx_gpio.c:(.init.text+0x42): undefined reference to
>  `__auxiliary_driver_register'
> 
> warnings:
> unmet direct dependencies detected for GPIOLIB_IRQCHIP when selected by
>  GP_PCI1XXXX

Same here.

> 
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver
>  for the PIO function in the multi-function endpoint of pci1xxxx device.")

That all needs to be on one line.

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
>  drivers/misc/mchp_pci1xxxx/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

And as you said, no v2 information :(

v3 please?

thanks,

greg k-h

  reply	other threads:[~2022-09-06 11:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 10:36 [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix dependency issues in building the pci1xxxx's aux bus driver Kumaravel Thiagarajan
2022-09-06 11:05 ` Greg KH [this message]
2022-09-06 13:19   ` Kumaravel.Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yxcpc7ao10kytxbV@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kumaravel.thiagarajan@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox