[PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix dependency issues in building the pci1xxxx's aux bus driver.

[PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix dependency issues in building the pci1xxxx's aux bus driver.

[Kumaravel Thiagarajan]

build errors and warnings listed below and reported by kernel
test robot <lkp@intel.com> on the char-misc-next branch are
fixed in this add-on patch.

errors:
ERROR: modpost: "auxiliary_device_init"
 [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!
ERROR: modpost: "__auxiliary_device_add"
 [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!
ERROR: modpost: "auxiliary_driver_unregister"
 [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
ERROR: modpost: "__auxiliary_driver_register"
 [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.o:
 in function `gp_aux_bus_probe.part.0':
mchp_pci1xxxx_gp.c:(.text+0x342): undefined reference to
 `auxiliary_device_init'
ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x392):
 undefined reference to `__auxiliary_device_add'
ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x5c2):
 undefined reference to `auxiliary_device_init'
ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x612):
 undefined reference to `__auxiliary_device_add'
ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.o:
 in function `pci1xxxx_gpio_driver_init':
 mchp_pci1xxxx_gpio.c:(.init.text+0x42): undefined reference to
 `__auxiliary_driver_register'

warnings:
unmet direct dependencies detected for GPIOLIB_IRQCHIP when selected by
 GP_PCI1XXXX

Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver
 for the PIO function in the multi-function endpoint of pci1xxxx device.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
---
 drivers/misc/mchp_pci1xxxx/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/mchp_pci1xxxx/Kconfig b/drivers/misc/mchp_pci1xxxx/Kconfig
index f6a6970d2a59..4abb47de7219 100644
--- a/drivers/misc/mchp_pci1xxxx/Kconfig
+++ b/drivers/misc/mchp_pci1xxxx/Kconfig
@@ -1,7 +1,9 @@
 config GP_PCI1XXXX
        tristate "Microchip PCI1XXXX PCIe to GPIO Expander + OTP/EEPROM manager"
-       depends on PCI	
+       depends on PCI
+       depends on GPIOLIB
        select GPIOLIB_IRQCHIP
+       select AUXILIARY_BUS
        help
          PCI1XXXX is a PCIe GEN 3 switch with one of the endpoints having
          multiple functions and one of the functions is a GPIO controller
-- 
2.25.1

Re: [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix dependency issues in building the pci1xxxx's aux bus driver.

[Greg KH]

On Tue, Sep 06, 2022 at 04:06:58PM +0530, Kumaravel Thiagarajan wrote:
> build errors and warnings listed below and reported by kernel
> test robot <lkp@intel.com> on the char-misc-next branch are
> fixed in this add-on patch.
> 
> errors:
> ERROR: modpost: "auxiliary_device_init"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!

These lines should now be wrapped, it's ok to have long lines that show
the error messages.

> ERROR: modpost: "__auxiliary_device_add"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!
> ERROR: modpost: "auxiliary_driver_unregister"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> ERROR: modpost: "__auxiliary_driver_register"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.o:
>  in function `gp_aux_bus_probe.part.0':
> mchp_pci1xxxx_gp.c:(.text+0x342): undefined reference to
>  `auxiliary_device_init'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x392):
>  undefined reference to `__auxiliary_device_add'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x5c2):
>  undefined reference to `auxiliary_device_init'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x612):
>  undefined reference to `__auxiliary_device_add'
> ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.o:
>  in function `pci1xxxx_gpio_driver_init':
>  mchp_pci1xxxx_gpio.c:(.init.text+0x42): undefined reference to
>  `__auxiliary_driver_register'
> 
> warnings:
> unmet direct dependencies detected for GPIOLIB_IRQCHIP when selected by
>  GP_PCI1XXXX

Same here.

> 
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver
>  for the PIO function in the multi-function endpoint of pci1xxxx device.")

That all needs to be on one line.

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
>  drivers/misc/mchp_pci1xxxx/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

And as you said, no v2 information :(

v3 please?

thanks,

greg k-h

RE: [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix dependency issues in building the pci1xxxx's aux bus driver.

[Kumaravel.Thiagarajan]

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, September 6, 2022 4:35 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Cc: linux-kernel@vger.kernel.org; kbuild-all@lists.01.org; lkp@intel.com
> Subject: Re: [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix
> dependency issues in building the pci1xxxx's aux bus driver.
> 
> 
> On Tue, Sep 06, 2022 at 04:06:58PM +0530, Kumaravel Thiagarajan wrote:
> > build errors and warnings listed below and reported by kernel test
> > robot <lkp@intel.com> on the char-misc-next branch are fixed in this
> > add-on patch.
> >
> > errors:
> > ERROR: modpost: "auxiliary_device_init"
> >  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!
> 
> These lines should now be wrapped, it's ok to have long lines that show the
> error messages.
You meant should not be wrapped? I have corrected this.

> 
> > ERROR: modpost: "__auxiliary_device_add"
> >  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!
> > ERROR: modpost: "auxiliary_driver_unregister"
> >  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> > ERROR: modpost: "__auxiliary_driver_register"
> >  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> > ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.o:
> >  in function `gp_aux_bus_probe.part.0':
> > mchp_pci1xxxx_gp.c:(.text+0x342): undefined reference to
> > `auxiliary_device_init'
> > ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x392):
> >  undefined reference to `__auxiliary_device_add'
> > ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x5c2):
> >  undefined reference to `auxiliary_device_init'
> > ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x612):
> >  undefined reference to `__auxiliary_device_add'
> > ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.o:
> >  in function `pci1xxxx_gpio_driver_init':
> >  mchp_pci1xxxx_gpio.c:(.init.text+0x42): undefined reference to
> > `__auxiliary_driver_register'
> >
> > warnings:
> > unmet direct dependencies detected for GPIOLIB_IRQCHIP when selected
> > by  GP_PCI1XXXX
> 
> Same here.
Corrected this too.

> 
> >
> > Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus
> > driver  for the PIO function in the multi-function endpoint of
> > pci1xxxx device.")
> 
> That all needs to be on one line.
Corrected this too.

> 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Kumaravel Thiagarajan
> > <kumaravel.thiagarajan@microchip.com>
> > ---
> >  drivers/misc/mchp_pci1xxxx/Kconfig | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> And as you said, no v2 information :(
> 
> v3 please?
Yes. I have sent v3.

Thank You.

Regards,
Kumaravel