From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA9BECAAD5 for ; Tue, 6 Sep 2022 11:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbiIFLa5 (ORCPT ); Tue, 6 Sep 2022 07:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232154AbiIFLay (ORCPT ); Tue, 6 Sep 2022 07:30:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A77931218; Tue, 6 Sep 2022 04:30:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC34B60C61; Tue, 6 Sep 2022 11:30:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53FC2C433D6; Tue, 6 Sep 2022 11:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662463851; bh=bm9uW+36QU1xAHJ+oVynEAhF11CfOTIcYyIVCyIxWQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AuWAOZpABzQWjhRFEGlEzovAMjqYP5gbx2CfPPN4+oWWFfy/3GWDEANvJUy53gZkq VWJVDLrAxbVlvcJZu3UwkmlK8PraTgk99sLgZfP+p27zMLLBLQ6/fEH6sFM8hFK2sH bUpyrIumm8r+LCVMCjEFEgQHOC3MxsYb1cgL9cjZLg8IVjnnqkxPPoTaUzoS4itTQJ AOZQpg7aJK2Gp1UyXQS7aGuZafIND20w87iIoGU1OEMTSR+KE65l/32oDQUpr0yT+a s525IDq+7dqQ/gbrXrGJA8wonnoHLr7bNBRSSpbXpcOxpvqjz9P64BmKzTpJVzkA/y XXjMl/V2ztJWw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oVWn8-0001e0-0d; Tue, 06 Sep 2022 13:30:54 +0200 Date: Tue, 6 Sep 2022 13:30:54 +0200 From: Johan Hovold To: Jiri Slaby Cc: gregkh@linuxfoundation.org, Ilpo =?utf-8?B?SsOkcnZpbmVu?= , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Tobias Klauser , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Vladimir Zapolskiy , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , Russell King , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Pali =?utf-8?B?Um9ow6Fy?= , Kevin Cernekee , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 0/4] tty: TX helpers Message-ID: References: <20220906104805.23211-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906104805.23211-1-jslaby@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 12:48:01PM +0200, Jiri Slaby wrote: > This series introduces DEFINE_UART_PORT_TX_HELPER + > DEFINE_UART_PORT_TX_HELPER_LIMITED TX helpers. See PATCH 2/4 for the > details. Comments welcome. > > Then it switches drivers to use them. First, to > DEFINE_UART_PORT_TX_HELPER() in 3/4 and then > DEFINE_UART_PORT_TX_HELPER_LIMITED() in 4/4. > > The diffstat of patches 3+4 is as follows: > 26 files changed, 191 insertions(+), 823 deletions(-) > which appears to be nice. Not really. This is horrid. Quality can't be measured in LoC (only). The resulting code is unreadable. And for no good reason. [ And note that you're "saving" something like 20 lines per driver: 12 files changed, 84 insertions(+), 349 deletions(-) ] NAK Johan