Re: [PATCH v2] mm: use mem_map_offset instead of mem_map_next

Matthew Wilcox
2022-09-05T15:27:17Z

On Mon, Sep 05, 2022 at 06:09:19AM +0000, Cheng Li wrote:
> To handle discontiguity case, mem_map_next() has a parameter named
> `offset`. As a function caller, one would be confused why "get
> next entry" needs a parameter named "offset". The other drawback of
> mem_map_next() is that the callers must take care of the map between
> parameter "iter" and "offset", otherwise we may get an hole or
> duplication during iteration. So we use mem_map_offset instead of
> mem_map_next.

Per my previous email, use nth_page(), not mem_map_offset().