From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] perf dlfilter: dlfilter-show-cycles: Fix types for print format
Date: Tue, 6 Sep 2022 09:58:59 -0300 [thread overview]
Message-ID: <YxdEE331EyEBEGr4@kernel.org> (raw)
In-Reply-To: <20220905074735.4513-1-adrian.hunter@intel.com>
Em Mon, Sep 05, 2022 at 10:47:35AM +0300, Adrian Hunter escreveu:
> Avoid compiler warning about format %llu that expects long long unsigned
> int but argument has type __u64.
>
> Fixes: c3afd6e50fce ("perf dlfilter: Add dlfilter-show-cycles")
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
>
> Changes in V2:
>
> Add fixes tag
Thanks, applied.
- Arnaldo
>
> tools/perf/dlfilters/dlfilter-show-cycles.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/dlfilters/dlfilter-show-cycles.c b/tools/perf/dlfilters/dlfilter-show-cycles.c
> index 9eccc97bff82..6d47298ebe9f 100644
> --- a/tools/perf/dlfilters/dlfilter-show-cycles.c
> +++ b/tools/perf/dlfilters/dlfilter-show-cycles.c
> @@ -98,9 +98,9 @@ int filter_event_early(void *data, const struct perf_dlfilter_sample *sample, vo
> static void print_vals(__u64 cycles, __u64 delta)
> {
> if (delta)
> - printf("%10llu %10llu ", cycles, delta);
> + printf("%10llu %10llu ", (unsigned long long)cycles, (unsigned long long)delta);
> else
> - printf("%10llu %10s ", cycles, "");
> + printf("%10llu %10s ", (unsigned long long)cycles, "");
> }
>
> int filter_event(void *data, const struct perf_dlfilter_sample *sample, void *ctx)
> --
> 2.25.1
--
- Arnaldo
prev parent reply other threads:[~2022-09-06 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 7:47 [PATCH V2] perf dlfilter: dlfilter-show-cycles: Fix types for print format Adrian Hunter
2022-09-06 12:58 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxdEE331EyEBEGr4@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox