From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10AFC6FA89 for ; Wed, 7 Sep 2022 14:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229446AbiIGO2V (ORCPT ); Wed, 7 Sep 2022 10:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbiIGO2R (ORCPT ); Wed, 7 Sep 2022 10:28:17 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A9679635 for ; Wed, 7 Sep 2022 07:27:53 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id b21so1820660plz.7 for ; Wed, 07 Sep 2022 07:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=9XYS+Kgfb1igJPu9ypOIGlz79nZqVIH51hI/0E5X5eM=; b=Bv3u2O5q2uJVe3HgYKCpkwW3hIjKkeJnM85rvsLdQhPO4kzJKsS9ham5jES+6lG9td gfZTWjCH/qAqSa/tqaQb0OgjHGOrc531I5mAGHtbGRAavJjsweH8RmfDycY9cyKLX3mi Tz+Dw0CBx5MoMq+fIGFMbRB4Lc3E8G9I7Oa5hmiUGMwRk7nakoNIhy+NKV2ZADTH7NP/ oi2FsUDJWn8JUZuk3Pa1R6ozwniM48YqAv9Khd+Q5o94178YHFzvvX0FkvZH46dNofGA EWzHAk2tPugmr4DjqSBo3GcPjNpGAozoBqHiZZieYDxyfbeho8CKNYUa7rir8gjGfxIh VQzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=9XYS+Kgfb1igJPu9ypOIGlz79nZqVIH51hI/0E5X5eM=; b=IbRbeU2hXejoCZsQXuQmZ/kn98cjWH9MWLfyPTofM2cc16TK7TMLyLmndvSUD2Qvqm emDTKhoqlmCECBTafkg5h4zNBV8YPvenxcBl/fbsytFBy6Lb4KVvwIcN7ASnzantyQex doEe03V+yr874x1k75RS3b3jvwGKReWnAaAiIxzTZ/dyylMQV3VU5GyqTG0mfKcR4Z09 bgYgGaGoJj7hF+Z7aCeuzewjmgkFn7QTf6pHEcKymHK5VHJuw8A+aeOip/d9adwiBwem OJ3n+xC1N0QfNvTYOd2XPPZLWybkyh4ZZJrADvj8QqtdVZ2P4WBbkmZRcib2BYs6sV1S GQAA== X-Gm-Message-State: ACgBeo1ugypXkkGmJdLD5AVRzjVo90nMfHOSdPiHJXpaG7K4jyR+c1+2 ucYPpy7lJ6hpeaDkWoOyxGcgEQ== X-Google-Smtp-Source: AA6agR7c6O5T5fX9brggCj/jzZQi8hBuMiaraeBpsDLiQih1cZLOe/O5Rs1LqPfhJa/psb1gkAYOHw== X-Received: by 2002:a17:902:bc44:b0:176:909f:f636 with SMTP id t4-20020a170902bc4400b00176909ff636mr3883717plz.21.1662560821442; Wed, 07 Sep 2022 07:27:01 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id a3-20020a621a03000000b0053e7495a395sm1721141pfa.122.2022.09.07.07.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 07:27:01 -0700 (PDT) Date: Wed, 7 Sep 2022 14:26:57 +0000 From: Sean Christopherson To: Miaohe Lin Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: x86/mmu: add missing update to max_mmu_rmap_size Message-ID: References: <20220907080657.42898-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220907080657.42898-1-linmiaohe@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07, 2022, Miaohe Lin wrote: > The update to statistic max_mmu_rmap_size is unintentionally removed by > commit 4293ddb788c1 ("KVM: x86/mmu: Remove redundant spte present check > in mmu_set_spte"). Add missing update to it or max_mmu_rmap_size will > always be nonsensical 0. > > Fixes: 4293ddb788c1 ("KVM: x86/mmu: Remove redundant spte present check in mmu_set_spte") For anyone else wondering "how did so many reviewers miss this obvious bug?", the answer is that the reviews were collected for v3 and earlier, and the mishandled merge conflict only showed up in v4. > Signed-off-by: Miaohe Lin > --- Reviewed-by: Sean Christopherson Paolo, do you want to grab this for 6.0?