public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: "Zhou, Jie2X" <jie2x.zhou@intel.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	"andrii@kernel.org" <andrii@kernel.org>,
	"mykolal@fb.com" <mykolal@fb.com>,
	"ast@kernel.org" <ast@kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"martin.lau@linux.dev" <martin.lau@linux.dev>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"hawk@kernel.org" <hawk@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Li, Philip" <philip.li@intel.com>,
	"petrm@nvidia.com" <petrm@nvidia.com>
Subject: Re: test ./tools/testing/selftests/bpf/test_offload.py failed
Date: Thu, 8 Sep 2022 09:23:48 +0300	[thread overview]
Message-ID: <YxmKdBVkNCPF4Kob@shredder> (raw)
In-Reply-To: <CY4PR11MB132098D8E47E38FD945E6398C5409@CY4PR11MB1320.namprd11.prod.outlook.com>

On Thu, Sep 08, 2022 at 03:10:51AM +0000, Zhou, Jie2X wrote:
> My error is  "Exception: Command failed: cat /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex"

This one is solved by the netdevsim patch ([2]).

> Do you get [1]error, after patch [2]?

Yes. Maybe you do not see it because you have an older bpftool without
"libbpf_strict" feature:

$ bpftool --version
bpftool v6.8.0
using libbpf v0.8
features: libbfd, libbpf_strict, skeletons

> [1]
> # bpftool prog load /home/idosch/code/linux/tools/testing/selftests/bpf/sample_ret0.o /sys/fs/bpf/nooffload type xdp
> Error: object file doesn't contain any bpf program
> Warning: bpftool is now running in libbpf strict mode and has more stringent requirements about BPF programs.
> If it used to work for this object file but now doesn't, see --legacy option for more details.
> 
> [2]
> diff --git a/drivers/net/netdevsim/hwstats.c b/drivers/net/netdevsim/hwstats.c
> index 605a38e16db0..0e58aa7f0374 100644
> --- a/drivers/net/netdevsim/hwstats.c
> +++ b/drivers/net/netdevsim/hwstats.c
> @@ -433,11 +433,11 @@ int nsim_dev_hwstats_init(struct nsim_dev *nsim_dev)
>                 goto err_remove_hwstats_recursive;
>         }
> 
> -       debugfs_create_file("enable_ifindex", 0600, hwstats->l3_ddir, hwstats,
> +       debugfs_create_file("enable_ifindex", 0200, hwstats->l3_ddir, hwstats,
>                             &nsim_dev_hwstats_l3_enable_fops.fops);
> -       debugfs_create_file("disable_ifindex", 0600, hwstats->l3_ddir, hwstats,
> +       debugfs_create_file("disable_ifindex", 0200, hwstats->l3_ddir, hwstats,
>                             &nsim_dev_hwstats_l3_disable_fops.fops);
> -       debugfs_create_file("fail_next_enable", 0600, hwstats->l3_ddir, hwstats,
> +       debugfs_create_file("fail_next_enable", 0200, hwstats->l3_ddir, hwstats,
>                             &nsim_dev_hwstats_l3_fail_fops.fops);
> 
>         INIT_DELAYED_WORK(&hwstats->traffic_dw,

  reply	other threads:[~2022-09-08  6:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  5:16 test ./tools/testing/selftests/bpf/test_offload.py failed Jie2x Zhou
2022-09-07  6:43 ` Ido Schimmel
2022-09-07  8:51   ` Zhou, Jie2X
2022-09-07 16:08     ` Ido Schimmel
2022-09-08  3:10       ` Zhou, Jie2X
2022-09-08  6:23         ` Ido Schimmel [this message]
2022-09-08  7:44           ` Zhou, Jie2X
2022-09-08  8:03             ` Ido Schimmel
2022-09-09  9:11               ` Zhou, Jie2X

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxmKdBVkNCPF4Kob@shredder \
    --to=idosch@idosch.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=jie2x.zhou@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@nvidia.com \
    --cc=philip.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox