From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A17C38145 for ; Thu, 8 Sep 2022 15:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231495AbiIHP0f (ORCPT ); Thu, 8 Sep 2022 11:26:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232369AbiIHPZr (ORCPT ); Thu, 8 Sep 2022 11:25:47 -0400 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E84D1AE224 for ; Thu, 8 Sep 2022 08:25:38 -0700 (PDT) Received: by mail-qk1-f177.google.com with SMTP id i9so7208419qka.0 for ; Thu, 08 Sep 2022 08:25:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=We7YdNWL+dA6SvrcsgfeWC+uhCMnz0P9xITf03yypx8=; b=S6yX968R0PSQ5vvRpBoI3D+fVvYOS2cDyrN0vFbrxDCjkYTM5dHtdsB5QuuEQMDJq2 22GEdoeZIaVJp7gEDf8MrJUeos9pIEq9O0H/oJYSLbL5nEeMrRBtv/Q2pBzb4XiJpbbl QmPim36HxFhqnDtEqGqJhdz7fvaCKjnSuNQSBNtVtTsG36qJNDxDCTqXRYsMi1cxNyqs gGccXYEMJp2vlMrD8CaQsaNQAkzZWPMl4IF2AGUdYnAmoTooKlLHMCvDyWq/jJLM5EH9 nza5+wQNU4GaqUYp3IR56KRNjKUXCWo5Vqt3OMBnLhwOLdXz+OSlFpt1+PEm0MoKDBkn qKLA== X-Gm-Message-State: ACgBeo1W+0z+BwS/p95aAvZYY92YjnjE4f2gOSKh8ABwbhq4ltcw8P3O Y19upZ5692HdXlHghAJK6i84bV7ReK+L X-Google-Smtp-Source: AA6agR786+XZqALGz47aUlYlRGU0gUHtl1jtiHS/dbi/BYJRHk2Rm8IwMyj9N3uQYj24nkxsh4cIdA== X-Received: by 2002:a05:620a:2451:b0:6cb:b4db:a3ad with SMTP id h17-20020a05620a245100b006cbb4dba3admr5003410qkn.216.1662650737962; Thu, 08 Sep 2022 08:25:37 -0700 (PDT) Received: from localhost (pool-68-160-173-162.bstnma.fios.verizon.net. [68.160.173.162]) by smtp.gmail.com with ESMTPSA id s13-20020a05620a0bcd00b006bb82221013sm17379003qki.0.2022.09.08.08.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 08:25:37 -0700 (PDT) Date: Thu, 8 Sep 2022 11:25:36 -0400 From: Mike Snitzer To: Kees Cook Cc: agk@redhat.com, mka@chromium.org, dm-devel@redhat.com, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, sarthakkukreti@chromium.org Subject: Re: dm: verity-loadpin: Only trust verity targets with enforcement Message-ID: References: <20220907133055.1.Ic8a1dafe960dc0f8302e189642bc88ebb785d274@changeid> <166259004596.4128104.7200162640366282166.b4-ty@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166259004596.4128104.7200162640366282166.b4-ty@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07 2022 at 6:34P -0400, Kees Cook wrote: > On Wed, 7 Sep 2022 13:30:58 -0700, Matthias Kaehlcke wrote: > > Verity targets can be configured to ignore corrupted data blocks. > > LoadPin must only trust verity targets that are configured to > > perform some kind of enforcement when data corruption is detected, > > like returning an error, restarting the system or triggering a > > panic. > > > > > > [...] > > Applied to for-next/hardening, thanks! > > [1/1] dm: verity-loadpin: Only trust verity targets with enforcement > https://git.kernel.org/kees/c/2e1875c05267 Does this mean you're intending to send this upstream? I prefer to take all DM changes unless there is an external dependency. Thanks, Mike