From: Greg KH <gregkh@linuxfoundation.org>
To: Jim Lin <jilin@nvidia.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aniruddha TVS Rao <anrao@nvidia.com>
Subject: Re: [PATCH] usb: gadget: rndis: Avoid dereference before NULL check
Date: Fri, 9 Sep 2022 07:38:07 +0200 [thread overview]
Message-ID: <YxrRPxeh/iCeCW4R@kroah.com> (raw)
In-Reply-To: <20220908175615.5095-1-jilin@nvidia.com>
On Fri, Sep 09, 2022 at 01:56:15AM +0800, Jim Lin wrote:
> NULL check is performed after params->dev is dereferenced in
> dev_get_stats.
I do not understand this statement.
> Fixed by adding a NULL check before dereferencing params->dev and
> removing subsequent NULL checks for it.
>
> Signed-off-by: Aniruddha TVS Rao <anrao@nvidia.com>
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> ---
> drivers/usb/gadget/function/rndis.c | 37 ++++++++++++-----------------
> 1 file changed, 15 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
> index 64de9f1b874c..d2f18f34c8e5 100644
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -198,6 +198,9 @@ static int gen_ndis_query_resp(struct rndis_params *params, u32 OID, u8 *buf,
> outbuf = (__le32 *)&resp[1];
> resp->InformationBufferOffset = cpu_to_le32(16);
>
> + if (!params->dev)
> + return -ENODEV;
> +
As Sergey points out, this check is useless and the ones below should
also be removed.
But, why make this check at all, how did you trigger a problem with the
current code?
Are you using this driver? If so, why? It is totally broken (as per
the specification) and we really really need to just delete it from the
tree to prevent anyone else from ever using it.
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-09 5:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 17:56 [PATCH] usb: gadget: rndis: Avoid dereference before NULL check Jim Lin
2022-09-08 20:30 ` Sergey Shtylyov
2022-09-09 5:38 ` Greg KH [this message]
2022-09-09 14:43 ` Jim Lin
2022-09-09 18:07 ` gregkh
2022-09-22 21:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxrRPxeh/iCeCW4R@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anrao@nvidia.com \
--cc=balbi@kernel.org \
--cc=jilin@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox