From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593BDECAAA1 for ; Fri, 9 Sep 2022 09:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbiIIJkh (ORCPT ); Fri, 9 Sep 2022 05:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230402AbiIIJka (ORCPT ); Fri, 9 Sep 2022 05:40:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 108E39C525; Fri, 9 Sep 2022 02:40:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9845261F6A; Fri, 9 Sep 2022 09:40:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A696C433C1; Fri, 9 Sep 2022 09:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662716425; bh=HsfqPASjnakS+xsqfPpAn2Do0sUbq2U9xY/KUbbjIP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Np7qYKPDxkWRV3AzIEX0EEInSZkDu8nyjOKt/thmwV20qBJ/XehbSQ6RAFNU59mRz uIaN745OjFy8eeLD3llQbNIMMzzk93bzsvg8Ls+StIWbB0lsbujcMsfeQW0xO/odEb cVASnbjfzCf/mnDTH+NxBLvJcU0ZCdtWyY2YmnwPRZ8Mypx2gzn2xFFcncu/YIY7X5 F5faa52aFffAWRL/lOvU/lbc0yTJY3ZVrocrHLme32ptHBRTzjBfoOrBJYk8SC40mx gTzi+PGBo/WpCGibrG3zzCmh8Al0eTOlddTf3OG55JThKJUSZlkx4pnphVospe5Yhk cwxQVw9xK0u8A== Date: Fri, 9 Sep 2022 10:40:10 +0100 From: "Gustavo A. R. Silva" To: Hangyu Hua Cc: bvanassche@acm.org, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] infiniband: ulp: srpt: Use flex array destination for memcpy() Message-ID: References: <20220909022943.8896-1-hbh25y@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909022943.8896-1-hbh25y@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2022 at 10:29:43AM +0800, Hangyu Hua wrote: > In preparation for FORTIFY_SOURCE performing run-time destination buffer > bounds checking for memcpy(), specify the destination output buffer > explicitly, instead of asking memcpy() to write past the end of what looked > like a fixed-size object. > > Notice that srp_rsp[] is a pointer to a structure that contains > flexible-array member data[]: > > struct srp_rsp { > ... > __be32 sense_data_len; > __be32 resp_data_len; > u8 data[]; > }; > > link: https://github.com/KSPP/linux/issues/201 > Signed-off-by: Hangyu Hua Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c > index 21cbe30d526f..8c29e14150d3 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > @@ -1421,7 +1421,7 @@ static int srpt_build_cmd_rsp(struct srpt_rdma_ch *ch, > > srp_rsp->flags |= SRP_RSP_FLAG_SNSVALID; > srp_rsp->sense_data_len = cpu_to_be32(sense_data_len); > - memcpy(srp_rsp + 1, sense_data, sense_data_len); > + memcpy(srp_rsp->data, sense_data, sense_data_len); > } > > return sizeof(*srp_rsp) + sense_data_len; > -- > 2.34.1 >