From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
bhelgaas@google.com, kw@linux.com, robh@kernel.org,
vidyas@nvidia.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: endpoint: Use link_up() callback in place of LINK_UP notifier
Date: Fri, 9 Sep 2022 12:20:19 +0200 [thread overview]
Message-ID: <YxsTYzGkfzFiBIsq@lpieralisi> (raw)
In-Reply-To: <20220831082025.GC5076@thinkpad>
On Wed, Aug 31, 2022 at 01:50:25PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Aug 25, 2022 at 03:47:10PM +0530, Kishon Vijay Abraham I wrote:
> > Hi Mani,
> >
> > On 11/08/22 15:12, Manivannan Sadhasivam wrote:
> > > As a part of the transition towards callback mechanism for signalling the
> > > events from EPC to EPF, let's use the link_up() callback in the place of
> > > the LINK_UP notifier. This also removes the notifier support completely
> > > from the PCI endpoint framework.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > > drivers/pci/endpoint/functions/pci-epf-test.c | 33 ++++++-------------
> > > drivers/pci/endpoint/pci-epc-core.c | 8 +++--
> > > include/linux/pci-epc.h | 8 -----
> > > include/linux/pci-epf.h | 8 ++---
> > > 4 files changed, 18 insertions(+), 39 deletions(-)
> > >
> >
> > .
> > .
> > <snip>
> > .
> > .
> > > diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
> > > index 805f3d64f93b..a51ba9f158c3 100644
> > > --- a/drivers/pci/endpoint/pci-epc-core.c
> > > +++ b/drivers/pci/endpoint/pci-epc-core.c
> > > @@ -690,10 +690,15 @@ EXPORT_SYMBOL_GPL(pci_epc_remove_epf);
> > > */
> > > void pci_epc_linkup(struct pci_epc *epc)
> > > {
> > > + struct pci_epf *epf;
> > > +
> > > if (!epc || IS_ERR(epc))
> > > return;
> > >
> > > - atomic_notifier_call_chain(&epc->notifier, LINK_UP, NULL);
> > > + list_for_each_entry(epf, &epc->pci_epf, list) {
> > > + if (epf->event_ops->link_up)
> > > + epf->event_ops->link_up(epf);
> > > + }
> >
> > how do you ensure there is no race while invoking the call back
> > functions during add/remove of epf?
> >
>
> Good catch! These should be guarded by epf->lock.
I shall wait for v2 then and mark this one as "Changes requested".
Lorenzo
prev parent reply other threads:[~2022-09-09 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 9:42 [PATCH 0/2] PCI: endpoint: Rework the EPC to EPF notification Manivannan Sadhasivam
2022-08-11 9:42 ` [PATCH 1/2] PCI: endpoint: Use callback mechanism for passing events from EPC to EPF Manivannan Sadhasivam
2022-08-11 9:42 ` [PATCH 2/2] PCI: endpoint: Use link_up() callback in place of LINK_UP notifier Manivannan Sadhasivam
2022-08-25 10:17 ` Kishon Vijay Abraham I
2022-08-31 8:20 ` Manivannan Sadhasivam
2022-09-09 10:20 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxsTYzGkfzFiBIsq@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox