From: sdf@google.com
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>, Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
bpf@vger.kernel.org, Kan Liang <kan.liang@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH 2/3] perf/bpf: Always use perf callchains if exist
Date: Fri, 9 Sep 2022 14:55:28 -0700 [thread overview]
Message-ID: <Yxu2UCaofBIyrewX@google.com> (raw)
In-Reply-To: <20220908214104.3851807-2-namhyung@kernel.org>
On 09/08, Namhyung Kim wrote:
> If the perf_event has PERF_SAMPLE_CALLCHAIN, BPF can use it for stack
> trace.
> The problematic cases like PEBS and IBS already handled in the PMU driver
> and
> they filled the callchain info in the sample data. For others, we can
> call
> perf_callchain() before the BPF handler.
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
At least from the description it make sense. We're filling a callchain
when it's been requested by the event, but it's missing on the
sample data (aka, software fallback?). perf_callchain also seems to
always fallback to &__empty_callchain in case of an error, so seems
safe.
> ---
> kernel/bpf/stackmap.c | 4 ++--
> kernel/events/core.c | 12 ++++++++++--
> 2 files changed, 12 insertions(+), 4 deletions(-)
> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
> index 1adbe67cdb95..aecea7451b61 100644
> --- a/kernel/bpf/stackmap.c
> +++ b/kernel/bpf/stackmap.c
> @@ -338,7 +338,7 @@ BPF_CALL_3(bpf_get_stackid_pe, struct
> bpf_perf_event_data_kern *, ctx,
> int ret;
> /* perf_sample_data doesn't have callchain, use bpf_get_stackid */
> - if (!(event->attr.sample_type & __PERF_SAMPLE_CALLCHAIN_EARLY))
> + if (!(event->attr.sample_type & PERF_SAMPLE_CALLCHAIN))
> return bpf_get_stackid((unsigned long)(ctx->regs),
> (unsigned long) map, flags, 0, 0);
> @@ -506,7 +506,7 @@ BPF_CALL_4(bpf_get_stack_pe, struct
> bpf_perf_event_data_kern *, ctx,
> int err = -EINVAL;
> __u64 nr_kernel;
> - if (!(event->attr.sample_type & __PERF_SAMPLE_CALLCHAIN_EARLY))
> + if (!(event->attr.sample_type & PERF_SAMPLE_CALLCHAIN))
> return __bpf_get_stack(regs, NULL, NULL, buf, size, flags);
> if (unlikely(flags & ~(BPF_F_SKIP_FIELD_MASK | BPF_F_USER_STACK |
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index b8af9fdbf26f..2ea93ce75ad4 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -10003,8 +10003,16 @@ static void bpf_overflow_handler(struct
> perf_event *event,
> goto out;
> rcu_read_lock();
> prog = READ_ONCE(event->prog);
> - if (prog)
> + if (prog) {
> + if (prog->call_get_stack &&
> + (event->attr.sample_type & PERF_SAMPLE_CALLCHAIN) &&
> + !(data->sample_flags & PERF_SAMPLE_CALLCHAIN)) {
> + data->callchain = perf_callchain(event, regs);
> + data->sample_flags |= PERF_SAMPLE_CALLCHAIN;
> + }
> +
> ret = bpf_prog_run(prog, &ctx);
> + }
> rcu_read_unlock();
> out:
> __this_cpu_dec(bpf_prog_active);
> @@ -10030,7 +10038,7 @@ static int perf_event_set_bpf_handler(struct
> perf_event *event,
> if (event->attr.precise_ip &&
> prog->call_get_stack &&
> - (!(event->attr.sample_type & __PERF_SAMPLE_CALLCHAIN_EARLY) ||
> + (!(event->attr.sample_type & PERF_SAMPLE_CALLCHAIN) ||
> event->attr.exclude_callchain_kernel ||
> event->attr.exclude_callchain_user)) {
> /*
> --
> 2.37.2.789.g6183377224-goog
next prev parent reply other threads:[~2022-09-09 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 21:41 [PATCH 1/3] perf: Use sample_flags for callchain Namhyung Kim
2022-09-08 21:41 ` [PATCH 2/3] perf/bpf: Always use perf callchains if exist Namhyung Kim
2022-09-09 21:55 ` sdf [this message]
2022-09-15 14:16 ` [tip: perf/core] " tip-bot2 for Namhyung Kim
2022-09-08 21:41 ` [PATCH 3/3] perf: Kill __PERF_SAMPLE_CALLCHAIN_EARLY Namhyung Kim
2022-09-15 14:16 ` [tip: perf/core] " tip-bot2 for Namhyung Kim
2022-09-09 12:37 ` [PATCH 1/3] perf: Use sample_flags for callchain Liang, Kan
2022-09-15 14:16 ` [tip: perf/core] " tip-bot2 for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxu2UCaofBIyrewX@google.com \
--to=sdf@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kan.liang@linux.intel.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox