From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEC2ECAAA1 for ; Fri, 9 Sep 2022 21:43:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231617AbiIIVn1 (ORCPT ); Fri, 9 Sep 2022 17:43:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbiIIVnX (ORCPT ); Fri, 9 Sep 2022 17:43:23 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C8F13E4EF for ; Fri, 9 Sep 2022 14:43:22 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 184-20020a2507c1000000b00696056767cfso2644338ybh.22 for ; Fri, 09 Sep 2022 14:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date; bh=RQ/RHVVHpmpB1V0DuvGfzSeOFbDRdXln7rq3LTWarTA=; b=Y9COy7bDApy6jOXUDs8cE/zwtaXpJVQs2yW5bcVJUB9dEen41pIRSOfHXVEy3XpSMr In1BWDC4ycuBveJyi34VQdSRPykN8pakuW1CdhDdvg2KmEW/9K55JFtORM9Zzbuwc8UM YbQ/ghAlbbAAFF1kOkK5N9S89JsdjbS60gmnh6oNl/ut1jCSz21+k+9fiZIREwDWFrSK NXFJWd8OAt+sTzRI9S7CN1P8dYDaGrnXc4gqLtbT7mSzgg1U5JSXaL8E+FfXULJZ/rJM J2SMtm04BpMuLnTwrpW8SL7iid6zwqKbu6bKDIsl6pj5Y5HgtWT8O+Ee6YOi6s3hURjQ eKlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=RQ/RHVVHpmpB1V0DuvGfzSeOFbDRdXln7rq3LTWarTA=; b=T3CMXmxJGr2rv16GmuKehwZWJGlsa/XopbAtdOxBSEvSaaImPKxYg/U+yy7FshWwzM I4ImJh+OTqxUSuTUsJGYVoxThsytZ+LbE+YyYiAmmUQVMlA9nObavtbPqwLFddpdS6WX fkvkLf27Urk7OM24O9QP00pAmyTYrVj/IHNKqkqmQcnRPNXbxVqHK0tBhlInO4tlw3g2 KzdbiQJ0kAyvuq0emn/Wzi8ueiMD9eaoJNq+qfcDAio9FxmUwoPnpPWied/qwGa2G6bM Ce6UN90HjQX6moQliuUJf4tb/H6+2ZCSRfzn6iZm7gre7zLQ+uq2szk3GjkgGreE0tlE rbIA== X-Gm-Message-State: ACgBeo0u1OyPJPzhQzgkyi2Tlrl3yTkwAQSn8m/s90K50YModQjpjkOa oo6z6Divzi0wl3bxVKbVwKvbEdg= X-Google-Smtp-Source: AA6agR6hPX1FHMMsmDh95SYa0O35eolLvLx65t+G3+4vzi9V2C7ZvZaasr4ExgdC0ocMNamDN1DmEaw= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a25:bed1:0:b0:695:8192:8d1d with SMTP id k17-20020a25bed1000000b0069581928d1dmr13187190ybm.533.1662759800271; Fri, 09 Sep 2022 14:43:20 -0700 (PDT) Date: Fri, 9 Sep 2022 14:43:18 -0700 In-Reply-To: <20220909211540.GA11304@bytedance> Mime-Version: 1.0 References: <000000000000e506e905e836d9e7@google.com> <20220909211540.GA11304@bytedance> Message-ID: Subject: Re: [syzbot] WARNING in bpf_verifier_vlog From: sdf@google.com To: Peilin Ye Cc: Benjamin Tissoires , Andrii Nakryiko , Alexei Starovoitov , bpf , Daniel Borkmann , davem@davemloft.net, haoluo@google.com, hawk@kernel.org, John Fastabend , jolsa@kernel.org, KP Singh , kuba@kernel.org, lkml , llvm@lists.linux.dev, martin.lau@linux.dev, nathan@kernel.org, Nick Desaulniers , Networking , Song Liu , syzkaller-bugs@googlegroups.com, Tom Rix , Yonghong Song , Peilin Ye Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09, Peilin Ye wrote: > Hi all, > On Fri, Sep 09, 2022 at 12:54:06PM -0700, sdf@google.com wrote: > > On 09/09, Benjamin Tissoires wrote: > > Yeah, good point. I've run the repro. I think the issue is that > > syzkaller is able to pass btf with a super long random name which > > then hits BPF_VERIFIER_TMP_LOG_SIZE while printing the verifier > > log line. Seems like a non-issue to me, but maybe we need to > > add some extra validation.. > In btf_func_proto_check_meta(): > if (t->name_off) { > btf_verifier_log_type(env, t, "Invalid name"); > return -EINVAL; > } > In the verifier log, maybe we should just say that > BTF_KIND_FUNC_PROTO "must > not have a name" [1], instead of printing out the user-provided > (potentially very long) name and say it's "Invalid" ? > Similarly, for name-too-long errors, should we truncate the name to > KSYM_NAME_LEN bytes (see __btf_name_valid()) in the log ? Both suggestions sound good to me. Care to cook and send a patch with a fix? > [1] commit 2667a2626f4d ("bpf: btf: Add BTF_KIND_FUNC and > BTF_KIND_FUNC_PROTO") > Thanks, > Peilin Ye