From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeff Harris <jefftharris@gmail.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: serial: New xr20m117x driver questions
Date: Sat, 24 Sep 2022 08:56:58 +0200 [thread overview]
Message-ID: <Yy6qOmuuzIffRQGC@kroah.com> (raw)
In-Reply-To: <CAGMfbUO=Zy_nXJ9wKV5r2xRBuK7_X3kL2TvM1jWB_hTPUvhnbw@mail.gmail.com>
On Fri, Sep 23, 2022 at 11:29:52AM -0400, Jeff Harris wrote:
> I have a driver for the MaxLinear XR20M117x family of UARTs that I'd like
> to contribute but have a couple questions. The driver is heavily based on
> the existing sc16is7xx driver. The driver started with the sample driver
> from MaxLinear for Linux 3.x.x, but as the integration of their driver
> proceeded into our 4.4 kernel, there were features and fixes missing that
> were present in the current sc16is7xx driver.
>
> The register set is similar, but there are a few places where the behavior
> is different. Would it be best to create a new driver or add the XR20M117x
> UARTs to the sc16is7xx driver with a flag to choose one behavior or the
> other?
Probably a flag, but let's see the patch to be sure.
> I have developed and tested the driver as a back-port of the mainline
> sc16is7xx driver to the 4.4 kernel used on our embedded platform. I don't
> have a ready method to test the driver with a newer kernel (other than
> ensuring compilation success). Is that a concern for accepting the driver?
Please don't use any new devices with the obsolete and insecure and
out-of-date 4.4 kernel tree, that's going to be a regulatory nightmare
when you realize how broken it is.
Anyway, it has to work in the latest kernel tree for us to be able to
accept it as we can't go back in time and do new development on old
kernels :)
thanks,
greg k-h
prev parent reply other threads:[~2022-09-24 6:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 15:29 serial: New xr20m117x driver questions Jeff Harris
2022-09-24 6:56 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy6qOmuuzIffRQGC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jefftharris@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox