From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7584C07E9D for ; Sat, 24 Sep 2022 07:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233346AbiIXHPC (ORCPT ); Sat, 24 Sep 2022 03:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbiIXHO5 (ORCPT ); Sat, 24 Sep 2022 03:14:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F88B1CB29 for ; Sat, 24 Sep 2022 00:14:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 32133B80D83 for ; Sat, 24 Sep 2022 07:14:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 503F7C433C1; Sat, 24 Sep 2022 07:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664003692; bh=yFTm/FVYOxOnX82hlQYnJ9zyQLMQStELUrkKWp1iBOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nY+K2jomYMCfKj7L0KM9IkUlMAIE4FpVCt1dwg1e7k2TKImmhwsppEKH3KNjxfczz ObroygEtNfJqyL07zQ+Nh2NjzOL6Iib9TvttHlMgWIU8j0S1h2YSidHaO04QAjX9y1 O14zCg9CpuYBT3+iVmvn59pGZvs/NoYf19m6p+c68jRoyddoKDdZoBmGddo2BCK6Mi Nxdq/3iQHqZGQ0DfoHflCvr4AwdHr/+GgsFB7eT9mfg+Hspk/63dXWoqHnxxcz4UFu dXgiQZzcNY2l/OOUBJNjClYt/7qQA03NTKktxYvf6I1cJSaZHdO4Vw6mOPpSjMJSir 3wJgJthUxgSkw== Date: Sat, 24 Sep 2022 12:44:49 +0530 From: Vinod Koul To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Shinichiro Kawasaki , Miquel Raynal , Kishon Vijay Abraham I , "linux-phy@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Reset COMPHY registers before USB 3.0 power on Message-ID: References: <20220920121154.30115-1-pali@kernel.org> <20220921050300.riwyofdncxscrwe3@shindev> <20220921080557.jdg5wywpa5qxcyo2@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220921080557.jdg5wywpa5qxcyo2@pali> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-09-22, 10:05, Pali Rohár wrote: > On Wednesday 21 September 2022 05:03:01 Shinichiro Kawasaki wrote: > > On Sep 20, 2022 / 14:11, Pali Rohár wrote: > > > Turris MOX board with older ARM Trusted Firmware version v1.5 is not able > > > to detect any USB 3.0 device connected to USB-A port on Mox-A module after > > > commit 0a6fc70d76bd ("phy: marvell: phy-mvebu-a3700-comphy: Remove broken > > > reset support"). On the other hand USB 2.0 devices connected to the same > > > USB-A port are working fine. > > > > > > It looks as if the older firmware configures COMPHY registers for USB 3.0 > > > somehow incompatibly for kernel driver. Experiments show that resetting > > > COMPHY registers via setting SFT_RST auto-clearing bit in COMPHY_SFT_RESET > > > register fixes this issue. > > > > > > Reset the COMPHY in mvebu_a3700_comphy_usb3_power_on() function as a first > > > step after selecting COMPHY lane and USB 3.0 function. With this change > > > Turris MOX board can successfully detect USB 3.0 devices again. > > > > > > Before the above mentioned commit this reset was implemented in PHY reset > > > method, so this is the reason why there was no issue with older firmware > > > version then. > > > > > > Fixes: 0a6fc70d76bd ("phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support") > > > Reported-by: Marek Behún > > > Signed-off-by: Pali Rohár > > > --- > > > Shinichiro, could you please check that all USB functionality still > > > works correctly on your board? > > > --- > > > > Sure. TL;DR, this patch works ok for my espressobin v7 board. > > > > Tested-by: Shin'ichiro Kawasaki > > > > I prepared base kernel v5.19.10 applying the commit 0a6fc70d76bd. Regardless > > whether this fix patch for Turrix MOX board is applied or not, two USB ports on > > my esprssobin v7 board worked as expected. I confirmed it by using USB thumb > > drive. The drive was detected and its partition was mounted successfully using > > either of the two USB ports. > > Thank you for testing! Anyway, please check that USB 3.0 device is > working fine. Because as I wrote in commit message, on Turris Mox was > USB 2.0 device working fine, but USB 3.0 not. And maybe check in system update the log now? > (lsusb) that USB 3.0 device was really detected as USB 3.0 because USB > 3.0 devices have supported also fallback USB 2.0/1.x legacy mode. > > > I also confirmed SATA port is ok (my SSD card was detected without error > > message) and three network ports works ok ("Link is Up" message on network cable > > connection). I did same confirmations with the latest firmware (TF-A and U-boot) > > and old firmware (with version date in 2017). All looks good for me. > > > > -- > > Shin'ichiro Kawasaki -- ~Vinod