From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C780C32771 for ; Sat, 24 Sep 2022 18:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231462AbiIXSBo (ORCPT ); Sat, 24 Sep 2022 14:01:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbiIXSBl (ORCPT ); Sat, 24 Sep 2022 14:01:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC13B419A5 for ; Sat, 24 Sep 2022 11:01:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E6C33B80E09 for ; Sat, 24 Sep 2022 18:01:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E701C433D6; Sat, 24 Sep 2022 18:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664042497; bh=g1afKKuq47C8aqaK2xeKV2IGCzYc5n8KN5uzi/pWP9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ukHGzjGLbEieplLBOGFLoYMwu/Kma8HXCc0HQEhSP6huqTx86ADD9S8JKWb9gPp7e pFKFzefMQOiZ5b7aF9jj7vLFCHxAwBWstdOJDxrH0oOAbNLLnIItGkcQptA6Hakg7T L1C9L1oJP3XExK9czHPcO+GULB31RHCaxEfMoHNOeDZEaL7UXBxfsYYzL+07dAfU7T YQqm4XT8TCGhMTm7ew/NDcY1U7+2FG2syrn8Btz3TdU4YEX2SkrBsPH3UNkBynHJVY ry3COZ3RhpeaR1BO6AzR2hggWwCx3Q/z+MlBzgicQNf13VRFILO3PPR61LzHIXyL2l 4OPGQEpzmM4kw== Date: Sat, 24 Sep 2022 19:01:29 +0100 From: Conor Dooley To: Chris Stillson Cc: Samuel Holland , Greentime Hu , Guo Ren , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Anup Patel , Atish Patra , Oleg Nesterov , Guo Ren , Heinrich Schuchardt , Arnaud Pouliquen , Paolo Bonzini , Alexandre Ghiti , Arnd Bergmann , Heiko Stuebner , Jisheng Zhang , Dao Lu , Sunil V L , Ruinland Tsai , Han-Kuan Chen , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 05/17] riscv: Add has_vector/riscv_vsize to save vector features. Message-ID: References: <20220921214439.1491510-1-stillson@rivosinc.com> <20220921214439.1491510-5-stillson@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2022 at 09:27:01AM -0700, Chris Stillson wrote: > On Wed, Sep 21, 2022 at 9:23 PM Samuel Holland wrote: > > > > On 9/21/22 16:43, Chris Stillson wrote: > > > From: Greentime Hu > > > > > > This patch is used to detect vector support status of CPU and use > > > riscv_vsize to save the size of all the vector registers. It assumes > > > all harts has the same capabilities in SMP system. > > > > > > [guoren@linux.alibaba.com: add has_vector checking] > > > Co-developed-by: Guo Ren > > > Signed-off-by: Guo Ren > > > Co-developed-by: Vincent Chen > > > Signed-off-by: Vincent Chen > > > Signed-off-by: Greentime Hu > > > --- > > > arch/riscv/include/asm/vector.h | 14 +++++ > > > arch/riscv/kernel/cpufeature.c | 19 +++++++ > > > arch/riscv/kernel/riscv_ksyms.c | 6 +++ > > > arch/riscv/kernel/vector.S | 93 +++++++++++++++++++++++++++++++++ > > > > This file is not added to the Makefile until patch 8. > (resending, as I forgot to set it to plain mail) And please don't top post either :) > This is the way the original set of patches worked. I tried to change > them as little as possible for the rebase. What is your goal with the series? Are you going to work on getting the whole thing merged, or just looking to tack your patch onto the end of the on-going series? There were two warnings from LKP & some comments from reviewers on v10, I assume that you did not make the changes those reviewers requested as the build warnings didn't get fixed. https://lore.kernel.org/linux-riscv/cover.1652257230.git.greentime.hu@sifive.com/ I see a couple more caused by another patch in the series too: ../arch/riscv/kvm/vcpu_vector.c:134:6: error: variable 'reg_val' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if ((rtype == KVM_REG_RISCV_VECTOR) && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../arch/riscv/kvm/vcpu_vector.c:139:7: note: uninitialized use occurs here if (!reg_val) ^~~~~~~ ../arch/riscv/kvm/vcpu_vector.c:134:2: note: remove the 'if' if its condition is always true if ((rtype == KVM_REG_RISCV_VECTOR) && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../arch/riscv/kvm/vcpu_vector.c:134:6: error: variable 'reg_val' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized] if ((rtype == KVM_REG_RISCV_VECTOR) && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../arch/riscv/kvm/vcpu_vector.c:139:7: note: uninitialized use occurs here if (!reg_val) ^~~~~~~ ../arch/riscv/kvm/vcpu_vector.c:134:6: note: remove the '&&' if its condition is always true if ((rtype == KVM_REG_RISCV_VECTOR) && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../arch/riscv/kvm/vcpu_vector.c:131:15: note: initialize the variable 'reg_val' to silence this warning void *reg_val; ^ = NULL 2 errors generated. Do you intend working on getting the series merged, or should I not bother actually reviewing the individual patches? If you do intend on getting it merged, can you please run checkpatch with the --strict option and clear up the stuff it whines about & sort out the Signed-off-bys in the series? Almost all the patches are missing your sign-off, which is required as you are now the submitter. You can also drop Greentime's signoff on any patch he is not the author of. Give it a few days before resubmitting though, to give people a chance at looking at the patchset first. Thanks, Conor. > > > 4 files changed, 132 insertions(+) > > > create mode 100644 arch/riscv/include/asm/vector.h > > > create mode 100644 arch/riscv/kernel/vector.S > > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv