From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C18CC6FA82 for ; Tue, 13 Sep 2022 07:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbiIMHkY (ORCPT ); Tue, 13 Sep 2022 03:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231130AbiIMHkP (ORCPT ); Tue, 13 Sep 2022 03:40:15 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB8F113E36 for ; Tue, 13 Sep 2022 00:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fue77bPZdaJAaSOH7eGxgtw/KYIpmA186iUr1AmIias=; b=01hMynooNnszICaf6NYn8Rojxv ScRBfM0qW1BPM379I/PwdJAzT9yFfkpejMs3Rdcxe75i8+6oOnrX6RlROFwayXFSb1iqiP+6vEt4c EwG98+H8EPBByUaGCQ34zQ1NLdxeUuEupLY+brY4s91n6wiwnosd+rMCYDMGuxvjTyAVpUpoOlzar IY3GgCmhkVuEdedgW/K9O0SVL6XbRSZf2B9nOOT/JKYhgtTC9xRqPtWwqH25xbhxpsb2Lo31hSbTR AYLhH/QABbyKih7jDukv9VE387sR5oKzcRTGXYLGvLtV5OmbzKPqsG3u+u6RSx5MNgk0pA/dnA4eL 9HLw/C2g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34284) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oY0WZ-0002ZS-S4; Tue, 13 Sep 2022 08:40:04 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oY0WZ-0000Va-6v; Tue, 13 Sep 2022 08:40:03 +0100 Date: Tue, 13 Sep 2022 08:40:03 +0100 From: "Russell King (Oracle)" To: Tang Bin Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: Fix wrong check Message-ID: References: <20220913072155.13392-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913072155.13392-1-tangbin@cmss.chinamobile.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 03:21:55PM +0800, Tang Bin wrote: > In the function imx8m_blk_ctrl_probe(), > dev_pm_domain_attach_by_name() may return NULL in some cases, > so IS_ERR() doesn't meet the requirements. Thus fix it. > > Fixes: 2684ac05a8c4 ("soc: imx: add i.MX8M blk-ctrl driver") > Signed-off-by: Tang Bin Duplicate of a later patch. See comments on later patch for why this is potentially wrong. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!