From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D79BEECAAD8 for ; Tue, 13 Sep 2022 17:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbiIMR0U (ORCPT ); Tue, 13 Sep 2022 13:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232797AbiIMRZs (ORCPT ); Tue, 13 Sep 2022 13:25:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D1D19F743; Tue, 13 Sep 2022 09:13:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3EAE9614FF; Tue, 13 Sep 2022 16:12:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28261C433D7; Tue, 13 Sep 2022 16:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663085577; bh=qnvPs8zuOVXMLGic2bOXDptky5r4yPlzmOAuJGbqcLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vJJt/wbK3ARGVFQAK83Sxh87+bFDfPW6vruBlq5svqco/4V01EyhiP4eGlJ3oLhYz 5roq4pvJofEzz/VSf4XmqXe4W2hbwdLqUywCqg5ddfAL7xQSrqvngxp0050X/5zzvF KjlQwUZ1EvytWPB4xRHWrDn/iGfapWuIMJA+IVT8= Date: Tue, 13 Sep 2022 18:13:21 +0200 From: Greg Kroah-Hartman To: Marc Kleine-Budde Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?iso-8859-1?B?Q3Pza+Fz?= Bence , Jakub Kicinski , Sasha Levin , Francesco Dolcini Subject: Re: [PATCH 5.19 123/192] net: fec: Use a spinlock to guard `fep->ptp_clk_on` Message-ID: References: <20220913140410.043243217@linuxfoundation.org> <20220913140416.124325107@linuxfoundation.org> <20220913141917.ukoid65sqao5f4lg@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220913141917.ukoid65sqao5f4lg@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 04:19:17PM +0200, Marc Kleine-Budde wrote: > Hello Greg, > > On 13.09.2022 16:03:49, Greg Kroah-Hartman wrote: > > From: Csókás Bence > > > > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ] > > > > Mutexes cannot be taken in a non-preemptible context, > > causing a panic in `fec_ptp_save_state()`. Replacing > > `ptp_clk_mutex` by `tmreg_lock` fixes this. > > > > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled") > > Fixes: f79959220fa5 ("fec: Restart PPS after link state change") > > Reported-by: Marc Kleine-Budde > > Link: https://lore.kernel.org/all/20220827160922.642zlcd5foopozru@pengutronix.de/ > > Signed-off-by: Csókás Bence > > Tested-by: Francesco Dolcini # Toradex Apalis iMX6 > > Link: https://lore.kernel.org/r/20220901140402.64804-1-csokas.bence@prolan.hu > > Signed-off-by: Jakub Kicinski > > Signed-off-by: Sasha Levin > > there's a revert pending for this patch: > > | https://lore.kernel.org/all/20220912070143.98153-1-francesco.dolcini@toradex.com > > ...as it causes troubles in 6.0-rc4: > > | https://lore.kernel.org/all/20220907143915.5w65kainpykfobte@pengutronix.de/ > | https://lore.kernel.org/all/CAHk-=wj1obPoTu1AHj9Bd_BGYjdjDyPP+vT5WMj8eheb3A9WHw@mail.gmail.com/ > > please drop this patch. Now dropped from all 3 queues, thanks. greg k-h