From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raul Rangel <rrangel@chromium.org>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
"jingle.wu" <jingle.wu@emc.com.tw>,
"Limonciello, Mario" <mario.limonciello@amd.com>,
Tim Van Patten <timvp@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@kernel.org>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq
Date: Wed, 14 Sep 2022 12:42:01 +0300 [thread overview]
Message-ID: <YyGh6Yjbb/5rkh35@smile.fi.intel.com> (raw)
In-Reply-To: <CAHQZ30DP1asiMj7hoebQQvGqE36sBDjaFmp3ju3eUEF1PruFeg@mail.gmail.com>
On Tue, Sep 13, 2022 at 12:56:37PM -0600, Raul Rangel wrote:
> On Tue, Sep 13, 2022 at 12:33 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Sep 13, 2022 at 12:07:53PM -0600, Raul Rangel wrote:
...
> > This is similar to what of_i2c_get_board_info() does, no?
> > Note: _get_ there.
>
> `*info` is an out parameter in that case. Ideally I would have
> `i2c_acpi_get_irq`, `acpi_dev_gpio_irq_get_wake`,
> `platform_get_irq_optional`, and `i2c_dev_irq_from_resources` all
> return a `struct irq_info {int irq; bool wake_capable;}`. This would
> be a larger change though.
Seems the ACPI analogue is i2c_acpi_fill_info(). Can we do it there?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-14 9:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 22:13 [PATCH v2 00/13] acpi: i2c: Use SharedAndWake and ExclusiveAndWake to enable wake irq Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 01/13] HID: i2c-hid: Use PM subsystem to manage " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 02/13] Input: elan_i2c - " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 03/13] Input: elants_i2c " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 04/13] Input: raydium_ts_i2c " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 05/13] gpiolib: acpi: Add wake_capable parameter to acpi_dev_gpio_irq_get_by Raul E Rangel
2022-09-13 17:10 ` Andy Shevchenko
2022-09-14 5:55 ` Mika Westerberg
2022-09-14 15:21 ` Raul Rangel
2022-09-12 22:13 ` [PATCH v2 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags Raul E Rangel
2022-09-13 17:21 ` Andy Shevchenko
2022-09-14 20:49 ` Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq Raul E Rangel
2022-09-13 7:28 ` Wolfram Sang
2022-09-13 15:51 ` Raul Rangel
2022-09-13 17:26 ` Andy Shevchenko
2022-09-13 18:07 ` Raul Rangel
2022-09-13 18:33 ` Andy Shevchenko
2022-09-13 18:56 ` Raul Rangel
2022-09-14 9:42 ` Andy Shevchenko [this message]
2022-09-14 18:33 ` Raul Rangel
2022-09-14 5:54 ` Mika Westerberg
2022-09-14 21:00 ` Raul Rangel
2022-09-12 22:13 ` [PATCH v2 08/13] ACPI: PM: Take wake IRQ into consideration when entering suspend-to-idle Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 09/13] HID: i2c-hid: acpi: Stop setting wakeup_capable Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 10/13] HID: i2c-hid: Don't set wake_capable and wake_irq Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 11/13] Input: elan_i2c - " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 12/13] Input: elants_i2c " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 13/13] Input: raydium_ts_i2c " Raul E Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyGh6Yjbb/5rkh35@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jingle.wu@emc.com.tw \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox