From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD755C6FA8A for ; Wed, 14 Sep 2022 13:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbiINNrT (ORCPT ); Wed, 14 Sep 2022 09:47:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229788AbiINNrP (ORCPT ); Wed, 14 Sep 2022 09:47:15 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F31EA74375 for ; Wed, 14 Sep 2022 06:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fOJqGTGPGQQQfGZceu13A6GHa3voDOXktFlfWZkhW7c=; b=UWOEEeBeYiLFLs71IC2xLzMU8N WcEifbsUrzkIiglqpYjIHbEgY5wYMyN4ixzT39lr/RQJVjMwwY5O83rkjv06hxLZwu3R0jJ40+txK fc90/JHuk55qcCLni75b+goNOCyr3HSEa2pzfVSKOoVbDSU+r77zV60s8f6mvF9GHIT3lyQmfclPl tVqP6MfOTJ3xKbmXAfxQ5LzhXjXOmEED+lfv5Uwyermfd3i0Tg6CfTmdS0zaB4UDYzTjaiqDS31zZ 8UCIjHZM5k8FqsQryH18QXntciWitcvrE0vBIAAjf7D4Bjs0PQNtgMFwZy5jTesEsxILPySj1xNjk bzKOMpuA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYSip-00CMv6-Ao; Wed, 14 Sep 2022 13:46:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 97B4330013F; Wed, 14 Sep 2022 15:46:34 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7BEE52B8AD400; Wed, 14 Sep 2022 15:46:34 +0200 (CEST) Date: Wed, 14 Sep 2022 15:46:34 +0200 From: Peter Zijlstra To: Ricardo Neri Cc: Juri Lelli , Vincent Guittot , Ricardo Neri , "Ravi V. Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J. Wysocki" , Srinivas Pandruvada , Steven Rostedt , Tim Chen , Valentin Schneider , x86@kernel.org, linux-kernel@vger.kernel.org, "Tim C . Chen" Subject: Re: [RFC PATCH 01/23] sched/task_struct: Introduce classes of tasks Message-ID: References: <20220909231205.14009-1-ricardo.neri-calderon@linux.intel.com> <20220909231205.14009-2-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909231205.14009-2-ricardo.neri-calderon@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2022 at 04:11:43PM -0700, Ricardo Neri wrote: > include/linux/sched.h | 7 +++++++ > init/Kconfig | 9 +++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index e7b2f8a5c711..acc33dbaa47c 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -117,6 +117,8 @@ struct task_group; > __TASK_TRACED | EXIT_DEAD | EXIT_ZOMBIE | \ > TASK_PARKED) > > +#define TASK_CLASS_UNCLASSIFIED -1 > +#ifdef CONFIG_SCHED_TASK_CLASSES > + /* Class of task that the scheduler uses for task placement decisions */ > + short class; > +#endif You're missing a hunk for init/init_task.c for this non-zero init value. Does we really have to use a signed type and non-zero init value?