From: Matthias Kaehlcke <mka@chromium.org>
To: Johan Hovold <johan@kernel.org>
Cc: Rajendra Nayak <quic_rjendra@quicinc.com>,
andersson@kernel.org, agross@kernel.org,
konrad.dybcio@somainline.org, mturquette@baylibre.com,
sboyd@kernel.org, johan+linaro@kernel.org,
quic_kriskura@quicinc.com, dianders@chromium.org,
linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] clk: qcom: gcc-sc7280: Update the .pwrsts for usb gdsc
Date: Wed, 14 Sep 2022 21:23:01 +0000 [thread overview]
Message-ID: <YyJGNR33JbHxWWYD@google.com> (raw)
In-Reply-To: <YyF+5CQqcLQlXvzV@hovoldconsulting.com>
On Wed, Sep 14, 2022 at 09:12:36AM +0200, Johan Hovold wrote:
> On Thu, Sep 01, 2022 at 09:04:55AM -0700, Matthias Kaehlcke wrote:
> > On Thu, Sep 01, 2022 at 03:47:56PM +0530, Rajendra Nayak wrote:
> > > USB on sc7280 cannot support wakeups from low power states
> > > if the GDSC is turned OFF. Update the .pwrsts for usb GDSC so it
> > > only transitions to RET in low power.
> > >
> > > Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> >
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > Tested-by: Matthias Kaehlcke <mka@chromium.org>
>
> Did you confirm that you actually hit the retention state?
No, how would I do that?
> IIUC, this series is equivalent to using ALWAYS_ON unless CX is actually
> powered off during suspend.
The count in /sys/kernel/debug/qcom_stats/cxsd increses with each suspend,
however it also does that with the GDSC configured as ALWAYS_ON and with
Rajendra's "arm64: dts: qcom: sc7280: Add required-opps for USB" [1], so
I guess that isn't the correct signal.
https://patchwork.kernel.org/project/linux-arm-msm/patch/20220914053017.23617-1-quic_rjendra@quicinc.com/
next prev parent reply other threads:[~2022-09-14 21:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 10:17 [PATCH 1/3] clk: qcom: gdsc: Fix the handling of PWRSTS_RET support Rajendra Nayak
2022-09-01 10:17 ` [PATCH 2/3] clk: qcom: gcc-sc7180: Update the .pwrsts for usb gdsc Rajendra Nayak
2022-09-01 16:04 ` Matthias Kaehlcke
2022-09-01 10:17 ` [PATCH 3/3] clk: qcom: gcc-sc7280: " Rajendra Nayak
2022-09-01 16:04 ` Matthias Kaehlcke
2022-09-14 7:12 ` Johan Hovold
2022-09-14 21:23 ` Matthias Kaehlcke [this message]
2022-09-15 7:25 ` Rajendra Nayak
2022-09-15 13:29 ` Rajendra Nayak
2022-09-15 16:43 ` Matthias Kaehlcke
2022-09-14 7:09 ` Johan Hovold
2022-09-14 8:37 ` Krishna Kurapati PSSNV
2022-09-14 8:53 ` Johan Hovold
2022-09-14 8:58 ` Rajendra Nayak
2022-09-14 9:07 ` Johan Hovold
2022-09-14 11:42 ` Krishna Kurapati PSSNV
2022-09-12 15:40 ` [PATCH 1/3] clk: qcom: gdsc: Fix the handling of PWRSTS_RET support Matthias Kaehlcke
2022-09-14 4:07 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyJGNR33JbHxWWYD@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dianders@chromium.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox