Re: [PATCH] i2c: mux: harden i2c_mux_alloc() against integer overflows

Dan Carpenter
2022-09-19T06:36:05Z

On Fri, Sep 16, 2022 at 08:31:58PM +0100, Wolfram Sang wrote:
>
> > > The new variable makes it more readable, but beyond that, do you see any
> > > reason not to just directly compose the calls?
> > >
> >
> > You could do that too.
> >
> > You pointed this out in your other email but the one thing that people
> > have to be careful of when assigning struct_size() is that the
> > "mux_size" variable has to be size_t.
> >
> > The math in submit_create() from drivers/gpu/drm/msm/msm_gem_submit.c
> > is so terribly unreadable. It works but it's so ugly. Unfortunately,
> > I'm the person who wrote it.
>
> I can't parse from that if the patch in question is okay or needs a
> respin? Could you kindly enlighten me?
>

It doesn't need a respin. We were just discussing related bugs with the
integer overflow safe functions.

regards,
dan carpenter