From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B003AECAAA1 for ; Thu, 15 Sep 2022 16:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbiIOQnm (ORCPT ); Thu, 15 Sep 2022 12:43:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiIOQnk (ORCPT ); Thu, 15 Sep 2022 12:43:40 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EFAB4F3B4 for ; Thu, 15 Sep 2022 09:43:38 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id g8so12728950iob.0 for ; Thu, 15 Sep 2022 09:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=ihRDwkA3/+uCxAKrHSmLGee9NmkEXol5SUJ6O91CNsQ=; b=ImI6oxn09GT5UW+MnR4ggV+ED5gD+svfD2kQMzQ4voej/W+eUfC3HFi6VBZwQXwecu voIEManlVi43NC/9tYTL0uTdZ1wEgFcoBx4a8ub3zfgvGaS5xc83X/EvtA6XpvC4raQg Z60mLYu8ZV4ww10k+iDFlynWBwENFebBhSxfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=ihRDwkA3/+uCxAKrHSmLGee9NmkEXol5SUJ6O91CNsQ=; b=kZ0k7MJKGrpVd8/DK9Vo9zFszBPGwtUZMno0YEKExiMuZ8MPNxTsmjQIba8v10RVAe FCX0L7endva2kGpPreCu9rsyxC2iyvjMYvg37iAZujsS81DbxsMzhwR8rHjlqTcdB8sY 5jlQyboVJZpY5j3GuizGM+gHAkWFo1XaUxUENn7xJcxdDm6rWRibO7sjpfBcKPv6VXe6 DOCpTi+HKxz8KvYNpZvbXwkEIaeQBQ0kzATGcfz+H3Tk1wJ3Kf3XGtpMWwi+roxuRdTI Jlft5GwQMfli4c9Gskw3vou8LiA5ZsqvfhXYAWT8zBVVxDUwePrBRd66b3EJg4v95cqu Z2xQ== X-Gm-Message-State: ACrzQf2IxfPmz+G9Kcpujx0BOvddiavmWdRjDqzOLzx/QyiF7FxjfW+1 LhQIcnsye2YlQE3a4wUaA5TmgA== X-Google-Smtp-Source: AMsMyM4BvQTKE/r4PZSeJj2dgAk4gub8S4eTFG15BDPyb9u9/mTbJ8nnopamaoZaf8gPyzuWM8LMEQ== X-Received: by 2002:a05:6638:19cf:b0:358:3dd3:2162 with SMTP id bi15-20020a05663819cf00b003583dd32162mr441054jab.185.1663260218045; Thu, 15 Sep 2022 09:43:38 -0700 (PDT) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id cb6-20020a0566381b0600b00349cee4ef4asm1327397jab.62.2022.09.15.09.43.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Sep 2022 09:43:37 -0700 (PDT) Date: Thu, 15 Sep 2022 16:43:36 +0000 From: Matthias Kaehlcke To: Rajendra Nayak Cc: Johan Hovold , andersson@kernel.org, agross@kernel.org, konrad.dybcio@somainline.org, mturquette@baylibre.com, sboyd@kernel.org, johan+linaro@kernel.org, quic_kriskura@quicinc.com, dianders@chromium.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] clk: qcom: gcc-sc7280: Update the .pwrsts for usb gdsc Message-ID: References: <20220901101756.28164-1-quic_rjendra@quicinc.com> <20220901101756.28164-3-quic_rjendra@quicinc.com> <4490d181-7bf2-791c-1778-1102e9adbc25@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2022 at 06:59:36PM +0530, Rajendra Nayak wrote: > > On 9/15/2022 12:55 PM, Rajendra Nayak wrote: > > > > > > On 9/15/2022 2:53 AM, Matthias Kaehlcke wrote: > > > On Wed, Sep 14, 2022 at 09:12:36AM +0200, Johan Hovold wrote: > > > > On Thu, Sep 01, 2022 at 09:04:55AM -0700, Matthias Kaehlcke wrote: > > > > > On Thu, Sep 01, 2022 at 03:47:56PM +0530, Rajendra Nayak wrote: > > > > > > USB on sc7280 cannot support wakeups from low power states > > > > > > if the GDSC is turned OFF. Update the .pwrsts for usb GDSC so it > > > > > > only transitions to RET in low power. > > > > > > > > > > > > Signed-off-by: Rajendra Nayak > > > > > > > > > > Reviewed-by: Matthias Kaehlcke > > > > > Tested-by: Matthias Kaehlcke > > > > > > > > Did you confirm that you actually hit the retention state? > > > > > > No, how would I do that? > > > > > > > IIUC, this series is equivalent to using ALWAYS_ON unless CX is actually > > > > powered off during suspend. > > > > > > The count in /sys/kernel/debug/qcom_stats/cxsd increses with each suspend, > > > however it also does that with the GDSC configured as ALWAYS_ON and with > > > Rajendra's "arm64: dts: qcom: sc7280: Add required-opps for USB" [1], so > > > > hmm, that's really not expected. With my above patch and with the GDSC as > > ALWAYS_ON there is a cx vote in suspend preventing cxsd so the counter > > should not go up. > > Perhaps you are missing '1b771839: clk: qcom: gdsc: enable optional power domain support' > in your tree? Indeed, that patch was missing in our tree, thanks for the pointer! With it the CXSD count does not increase when the GDSC is configured as ALWAYS_ON.