From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0EB5C54EE9 for ; Fri, 16 Sep 2022 12:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbiIPMmG (ORCPT ); Fri, 16 Sep 2022 08:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbiIPMmD (ORCPT ); Fri, 16 Sep 2022 08:42:03 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D017CA6C00 for ; Fri, 16 Sep 2022 05:42:01 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id k13so9597006ilc.11 for ; Fri, 16 Sep 2022 05:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=YlAL0BvKCH8NN/GcGwayEcshzaeRWejxCFhjRsByIp8=; b=XxjLFtm/UYQN6xTIhTDLAN69/gzCtD1gVd3BKEzWWbnNPC2RuCl6pcRT3YM406pZyA 9mlY3HMcYmkwNdvy868r9J+FGH7f7kbRRndHqll/f0l+lhY+W8HWzV9Qrv5SCP8Av+ZT lij9pcJ3iT7LYyyVJIEFB7Yj2DqIQ9bBcFnn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=YlAL0BvKCH8NN/GcGwayEcshzaeRWejxCFhjRsByIp8=; b=Ev15pT+w0opM0qQTh8K0RMuV/WWbnANYl/UZ0+giWaGgXJxZo/EPsmTcxSfRbMC6wS ivzcXZkIX7T9uZOs3gA0egRacGMVFKEQHgHtbQMvxMZI3uc6ueY9HoHodyxyzAbC1G8Z llBCblLsN43AQMmLYNKjK5p9MKehZUJLmdEDpsLXAkgJeGnwVW5lDld6hcYbNS39e6CG nPFXVixa3K2nCiZnKMNzl9lbzDduBOADDOeszHRj/EQeSqgcNMMO60OJC/hLH9bcYvmA fKZ8wz1lKXOzrFOpbsp+r11QmA7W/tOWtjJI6VylFyp/KTjQU+XnjArHB6lbgtwZQwMK RDhA== X-Gm-Message-State: ACrzQf0SOBD3Qf8IvFRN4mr4NTOywT3QVVsdKS14kXgEt/olKSIO9k8p l4qrvrSbFDxvfLM4559w7Qe9Gg== X-Google-Smtp-Source: AMsMyM5cAdcV+bPCyOY8Hu8lTDYaVfhr3D7UJ1X2dE9RPjICawOjxJYMU7AXuR2UKFxfi1By3X7oHg== X-Received: by 2002:a05:6e02:c84:b0:2f1:3e7d:8bf2 with SMTP id b4-20020a056e020c8400b002f13e7d8bf2mr2294547ile.272.1663332121227; Fri, 16 Sep 2022 05:42:01 -0700 (PDT) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id ct9-20020a056638488900b003583b307d55sm2228412jab.49.2022.09.16.05.42.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 05:42:00 -0700 (PDT) Date: Fri, 16 Sep 2022 12:42:00 +0000 From: Matthias Kaehlcke To: Rajendra Nayak Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sboyd@kernel.org, johan+linaro@kernel.org, quic_kriskura@quicinc.com, dianders@chromium.org Subject: Re: [Patch v2] arm64: dts: qcom: sc7280: Add required-opps for USB Message-ID: References: <20220916103124.30581-1-quic_rjendra@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220916103124.30581-1-quic_rjendra@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 04:01:24PM +0530, Rajendra Nayak wrote: > USB has a requirement to put a performance state vote on 'cx' > while active. Use 'required-opps' to pass this information from > device tree, and since all the GDSCs in GCC (including USB) are > sub-domains of cx, we also add cx as a power-domain for GCC. > Now when any of the consumers of the GDSCs (in this case USB) > votes on a perforamance state, genpd framework can identify that > the GDSC itself does not support a performance state and it > then propogates the vote to the parent, which in this case is cx. > > This change would also mean that any GDSC in GCC thats left enabled > during low power state (perhaps because its marked with a > ALWAYS_ON flag) can prevent the system from entering low power > since that would prevent cx from transitioning to low power. > Ideally any consumers that would need to have their devices > (partially) powered to support wakeups should look at making the > resp. GDSCs transtion to a Retention (PWRSTS_RET) state instead > of leaving them ALWAYS_ON. > > Signed-off-by: Rajendra Nayak I suppose a similar patch is needed for sc7180?