Re: [PATCH v3 5/9] i2c-mlxbf.c: support lock mechanism

Wolfram Sang
2022-09-17T18:25:38Z

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

> + /* Try to acquire the smbus gw lock before any reads of the GW register since
> + * a read sets the lock.
> + */

Please use kernel multiline comment style.

> @@ -792,6 +824,8 @@ mlxbf_i2c_smbus_start_transaction(struct mlxbf_i2c_priv *priv,
> priv->smbus->io + MLXBF_I2C_SMBUS_MASTER_FSM);
> }

Dunno if this is taste, but I think it is easier to follow the locking
when we have central acquire and release points for it. So, I'd suggest
to add something like

out_unlock:

here and then goto to this place from the other locations.

What do you think?

>
> + mlxbf_i2c_smbus_master_unlock(priv);
> +
> return ret;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]