From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF79BECAAA1 for ; Sun, 18 Sep 2022 02:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbiIRCnJ (ORCPT ); Sat, 17 Sep 2022 22:43:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiIRCnH (ORCPT ); Sat, 17 Sep 2022 22:43:07 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C69B0286CC for ; Sat, 17 Sep 2022 19:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=um5UnD1ZnyEAgcctB8e0bdxExLm3AihflJVjXCDL3Fo=; b=tg/t0BdHfoKvwqeStHEJvYxCKj rZLUKqRuZxEk9hbAMHPuAFwmEhGHIZ6DndFQ2wPvRlSV3suMSM4OyKJveh8Vv09AaMO2FKBCcA533 5H1Ut8f2doPHZ7EDBTjeUyRxhVkXnjyjkGvHFIxS3Gh3gHa7SyN8VVm51NpYowegkigee6Y7tJ6Fz pHpYSKZGN2R9BNFja/qEOggFQIRBJNfDS1bHEr/GyqPFNQpjCIgoLnf+axOH6JuoOyteMTlr7eChs rMizovJ1fSZAPgXEwPIBeApYRO8px2NjfuL0cpsy3ox6axpfpnPBRMv6yX/oG7VOGqURNrhSDS4dp 0i77AEbA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1oZkGj-000Okm-3D; Sun, 18 Sep 2022 02:42:54 +0000 Date: Sun, 18 Sep 2022 03:42:53 +0100 From: Al Viro To: Zhaoyang Huang Cc: "zhaoyang.huang" , "Eric W. Biederman" , LKML , Ke Wang Subject: Re: [PATCH] fs: use kvmalloc for big coredump file Message-ID: References: <1661842523-26716-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 18, 2022 at 10:29:10AM +0800, Zhaoyang Huang wrote: > loop Eric W > > On Tue, Aug 30, 2022 at 2:56 PM zhaoyang.huang > wrote: > > > > From: Zhaoyang Huang > > > > High order page allocation observed which even introduce kernel panic when generating > > coredump file, use kvmalloc_array instead of kmalloc_array Frankly, I would rather cap argc here - if you are trying to feed that many arguments to your userland helper, your core_pattern is probably bogus.