From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02246ECAAA1 for ; Mon, 19 Sep 2022 21:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbiISV1H (ORCPT ); Mon, 19 Sep 2022 17:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiISV1D (ORCPT ); Mon, 19 Sep 2022 17:27:03 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 494DE4D26B; Mon, 19 Sep 2022 14:27:03 -0700 (PDT) Date: Mon, 19 Sep 2022 21:26:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663622821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PBVzOIeI60u1nyDyEYcoeZ2gp8FehbJxyHNEiayMQ8Y=; b=wpN9zcZ5dGnUniJ0rzWsbEBotJaeINsx4mnOT8eMmrIZaemS9xW1DsdMKpRNFaijBsUubr ZU6UoZxzGF2gHC7+1u4KlqZ7o8vaC4xYgUCDnZIURyKfxiA9IL50DxyR2UVgBNEsvyLdCn o4GZZOIhCDG0DodcHRryqWyULT4xvd8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Jones , Anup Patel , Atish Patra , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Subject: Re: [PATCH 5/5] KVM: selftests: Dedup subtests of fix_hypercall_test Message-ID: References: <20220908233134.3523339-1-seanjc@google.com> <20220908233134.3523339-6-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220908233134.3523339-6-seanjc@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2022 at 11:31:34PM +0000, Sean Christopherson wrote: > Combine fix_hypercall_test's two subtests into a common routine, the only > difference between the two is whether or not disable the quirk. Passing > a boolean is a little gross, but using an enum to make it super obvious > that the callers are enabling/disabling the quirk seems like overkill. > Eh, good 'nuff. > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Oliver Upton -- Thanks, Oliver